-
Notifications
You must be signed in to change notification settings - Fork 44.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message about Pinecone initializing #1194
Message about Pinecone initializing #1194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look what we use for messages. You cannot just print.
please I need some help as this is my first pull request 1st approach but this message is of level = logging.info 2nd approach 3rd approach |
@p-i- @richbeales Could you assist him? |
Waiting for some hint. |
Maybe @BillSchumacher ? |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
3 similar comments
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the logger as intended
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
You accidentally deleted the file. Revert that commit please. You can do it from GitHub desktop UI or switch to your branch and run
and then commit and push that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix file deletion
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
thanks for pointing out |
I apologize to everyone for any problems or difficulties I may have caused and I appreciate your time and patience. |
@Ashutoshkataria19 the PRs is outdated, the file is now autogpt/memory/pinecone.py not scripts/memory/pinecone.py please rebase. |
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
I attempted to rebase my branch, hoping that updating my fork would resolve the issues. However, during the process, all the commits were inadvertently deleted, and the pull request was closed. I have now reopened the pull request with the same changes that @ntindle had approved. Could you please review the pull request again? |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
==========================================
- Coverage 49.20% 40.69% -8.51%
==========================================
Files 63 63
Lines 3014 3015 +1
Branches 496 496
==========================================
- Hits 1483 1227 -256
- Misses 1411 1716 +305
+ Partials 120 72 -48
... and 15 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@Ashutoshkataria19 This failed the lint check. Please run |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
237599c
Added a message: "Connecting Pinecone. This may take some time..."
close #987
Background
If the Pinecone index setup takes a noticeable amount of time, the console just stops. It is necessary to notify the user that the index is being configured now and this may take some time.
Changes
Added a message: "Connecting Pinecone. This may take some time..."
Documentation
Test Plan
PR Quality Checklist