-
Notifications
You must be signed in to change notification settings - Fork 44.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Chroma to augment and make LocalCache memory/embeddings pluggable #1027
Conversation
its ready for review :) |
great addition @sw-yx ! I hope it gets merged soon. |
@sw-yx There are conflicts |
whaaat i just made this PR yesterday and there are conflicts haha. will fix! |
We move fast, new conflicts can happen every 5 minutes here :) |
… swyx/extendLocalCache
@nponeccop i think i fixed the conflict! |
4c8aaa5
to
1b3f82e
Compare
… swyx/extendLocalCache
re-fixed new conflicts! @nponeccop what typically happens next? |
@sw-yx There are conflicts now |
… swyx/extendLocalCache
@nponeccop as far as i can tell i fixed the conflicts as of commit a6928c2. i've just updated my fork to current master but still not seeing any conflicts as of right now! |
@sw-yx There are both conflicts and CI failure now |
… swyx/extendLocalCache
…-GPT into swyx/extendLocalCache
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
no, it only has ~100 lines changed...? |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
009abd7
to
d753793
Compare
…-GPT into swyx/extendLocalCache
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
First of all: sorry for leaving this unresolved for so long. This is an interesting PR and unfortunately I'm only seeing it now for the first time. Since this PR, we have rebuilt the memory storage system (#4208) and removed all third-party memory stores, to make room for redeveloping the entire memory system without having to worry about maintaining multiple memory stores. For now, I can only close this, as the PR is based on a very much outdated version of the codebase and because we want to have only one memory backend until the memory system is in better shape. We would still be happy to have your involvement; feel free to join in on the action via discord! |
Background
The LocalCache memory backend implemented in #372 used a handrolled implementation of a storage engine, and the embedding strategy was pinned to
text-embedding-ada-002
which we may want to change/does cost money/latencyChanges
Documentation
in README
Test Plan
testing it locally
no new tests needed since this is a strict upgrade of LocalCache.
PR Quality Checklist