This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 564
Add voice command plugin #136
Open
armmarov
wants to merge
17
commits into
Significant-Gravitas:master
Choose a base branch
from
armmarov:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi @ntindle, how are you? I would like to ask if there is any problem trying this plugin (or maybe installing the dependencies)? |
ntindle
approved these changes
May 18, 2023
Can you take a look at the test failures? |
Hi @ntindle , i already fixed the issue |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 58.52% 61.32% +2.79%
==========================================
Files 36 39 +3
Lines 2122 2459 +337
Branches 222 257 +35
==========================================
+ Hits 1242 1508 +266
- Misses 858 921 +63
- Partials 22 30 +8
☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding function to have two ways conversation by adding voice command from user side.