Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Consolidate Scripts and add Makefile #2

Merged

Conversation

buckedunicorn
Copy link
Contributor

This PR consolidates the scripts used for cleaning, quality assurance, and code styling into a single Makefile.

The new Makefile includes three targets: clean, qa, and style, which replace the previous scripts in clean_all.sh, qa.bat, qa.sh, style.bat, and style.sh.

This change makes it easier to maintain and manage the project while providing a more consistent interface for developers to interact with various tasks.

@BillSchumacher
Copy link
Contributor

I like where you're going with this but I would like the bat files still since I don't usually install make on Windows.

@BillSchumacher
Copy link
Contributor

BillSchumacher commented Apr 16, 2023

If you want to consolidate those separately that would be awesome too.

@buckedunicorn
Copy link
Contributor Author

I like where you're going with this but I would like the bat files still since I don't usually install make on Windows.
If you want to consolidate those separately that would be awesome too.

Thanks for the feedback, @BillSchumacher! I've made some changes to the PR based on your suggestions. I consolidated the scripts into helpers.{bat,sh} files, which should work for both Windows and *nix systems. I also updated the Makefile to reduce code duplication and future maintenance needs. Additionally, I made some opinionated changes to the .editorconfig file, such as adding crlf line endings for the .bat files.

Since I'm not a regular Windows user, please let me know if there are any issues with the .bat files. I kept the commit that made changes to the .editorconfig file separate in case you want to cherry-pick those changes.

Thanks again for your feedback! Let me know if there's anything else I can do to improve this PR, or with the project!

@buckedunicorn buckedunicorn changed the title Proposal: Consolidate Scripts into Makefile Proposal: Consolidate Scripts and add Makefile Apr 16, 2023
@BillSchumacher BillSchumacher merged commit 2c8eb0f into Significant-Gravitas:master Apr 17, 2023
@buckedunicorn buckedunicorn deleted the proposal/makefile branch April 17, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants