feature: update tv4-formats to latest version #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two tests to make sure that timestamp validation is working. The first test 'ending with Z' will verify that a timestamp not ending with Z is rejected. This is the signalk spec regexp '.*Z'. The second test is more subtle and requires the date to be an actually valid timetamp. We currently use tv4-formats for this.
Upgrade tv4-formats to latest version which works well with Webpack. Previous versions used a try/catch import heuristic which does not play well with webpack. See ikr/tv4-formats@61450dc
tkurki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade tv4-formats to latest version which works well with Webpack.
Previous versions used a try/catch import heuristic which does not play
well with webpack.
See ikr/tv4-formats@61450dc
(This PR replaces #498 - It also includes added tests so that my mistake in the first PR does not happen again).