Typescript: index.js, config.js #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkurki
force-pushed
the
more-typescript
branch
2 times, most recently
from
255514d to
12e5824
Compare
tkurki
force-pushed
the
more-typescript
branch
from
12e5824 to
b47c45e
Compare
tkurki
changed the title
panaaj
reviewed
Nov 28, 2021
There was a problem hiding this comment.
Sorry didn't see the review request....It looks OK to me. I don't see any obvious red flags based on the plugin work I have done in the past.
Because this is just converting to Typescript my experience is that it really just needs to compile, the code function has not been changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the main index.js (App) and config to typescript