Fix: not sending delta when next position values are missing #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send delta with nextPoint.position value = null
panaaj
changed the title
tkurki
reviewed
Nov 12, 2024
|
Now that I think of it: at least BWC BWR also map to nextPoint, they should also be updated. |
tkurki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RMB, BWC and BWR sentence processing behaviour to send a delta when position field values are missing.
Current behaviour:
Whe position field values are missing, function does not return data and no delta is sent.
This means that clients are left unaware of a previously active destination being "de-activated" and will continue to show the destination as active.
FIx:
When position field values are missing, return data so that a delta is sent with
nextPoint.positionvalue = null.