Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mitre d3fend namespace #255

Merged
merged 5 commits into from
Aug 11, 2024
Merged

Conversation

nasbench
Copy link
Member

@nasbench nasbench commented Aug 11, 2024

This PR adds mitre d3fend tag namespace.

See SigmaHQ/sigma-specification#147 for the specification definition.

It also fixes a typo in ATT&CK function where in the allowed tags combined dict, the full dict was merged instead of only the keys of both mitre_attack_intrusion_sets and mitre_attack_software

TODO

Note: For now I generated the d3fend data manually with an ad-hoc script. In the future i'll add a script to the tools folder to automate updates.

Copy link
Member

@frack113 frack113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaspatzke thomaspatzke merged commit baa9d63 into SigmaHQ:main Aug 11, 2024
15 checks passed
@nasbench nasbench deleted the add-d3fend-tags branch August 11, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants