Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tags to use dashes #248

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Conversation

nasbench
Copy link
Member

@nasbench nasbench commented Aug 4, 2024

This PR updates the tags validator for the following namespaces.

  • CVE: Use dash instead of dot to conform with the rest of the tags
  • Detection: Use dash instead of underscore to conform with the rest of the tags
  • ATT&CK: Use dash instead of underscore to conform with the rest of the tags
  • TLP: Use a dash for amber+strict to conform with the rest of the tags

Fixes a couple of typos and added return types to some functions along the way.

All the rules on SigmaHQ rule repo are being updated in SigmaHQ/sigma#4950 to conform with the changes proposed here.

@nasbench
Copy link
Member Author

nasbench commented Aug 5, 2024

Sorry for the additional update. But since i changed it in the spec, we need to change it here too.

in the related field the type OBSOLETES will becomes OBSOLETE. Its more accurate to say a rule is obsolete.

@nasbench nasbench requested a review from frack113 August 5, 2024 08:51
Copy link
Member

@frack113 frack113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaspatzke thomaspatzke merged commit f753434 into SigmaHQ:main Aug 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants