Fix cidr expansion for backends that use custom wildcard char #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a backend defines `wildcard_multi` as something other than `*`, then it won't be parsed as a wildcard by `SigmaString` and will therefore be escaped when the `SigmaString` is converted to a regular string.
|
Thanks for the fix! First I've wondered why it works, now I know it and made some further enhancements and tests based on your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I ran into a bug while testing the
|cidrmodifier in a backend that uses the cidr wildcard logic fromTextQueryBackendand a wildcard character that isn't*.The condition
c-ip|cidr: "10.0.0.0/8"was converted into the following query:The wildcard (
%) should not have been escaped here.It turns out that when
SigmaCIDRExpression.expand()is called with a wildcard that isn't*, then it won't parsed as a wildcard bySigmaStringand will therefore be escaped when theSigmaStringis later converted back into a regular string.