Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json serialization of SigmaLogSource #123

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Fix json serialization of SigmaLogSource #123

merged 1 commit into from
Jun 19, 2023

Conversation

DenizenB
Copy link
Contributor

@DenizenB DenizenB commented Jun 19, 2023 •
edited
Loading

Hello, when trying to serialize a SigmaRule to json I was met with this error:

TypeError: Object of type SigmaRuleLocation is not JSON serializable

This PR converts the SigmaRuleLocation object to a string in the to_dict method, fixing json serialization of the dict generated by SigmaRuleLocation.to_dict().

@thomaspatzke thomaspatzke merged commit e47e61e into SigmaHQ:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenizenB @thomaspatzke