We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
SigmaCollection.errors is always empty because errors are not merged in the merge function.
Fix:
def merge(cls, collections : Iterable["SigmaCollection"], collect_errors) -> "SigmaCollection": """Merge multiple SigmaCollection objects into one and return it.""" if collect_errors: return cls([ rule for collection in collections for rule in collection ], [ error for collection in collections for error in collection.errors ] ) else: return cls([ rule for collection in collections for rule in collection ])
In load_ruleset() function return cls.merge(sigma_collections, collect_errors)
Regards, Céline
The text was updated successfully, but these errors were encountered:
Fix: Merging errors from SigmaCollection objects
789247d
Fixes Bug: sigma collections errors are not merged #112
thomaspatzke
No branches or pull requests
Hi,
SigmaCollection.errors is always empty because errors are not merged in the merge function.
Fix:
In load_ruleset() function return cls.merge(sigma_collections, collect_errors)
Regards,
Céline
The text was updated successfully, but these errors were encountered: