Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v2 exporter for clickhousemetricswrite #410

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Add v2 exporter for clickhousemetricswrite #410

merged 5 commits into from
Oct 14, 2024

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Sep 27, 2024 •
edited
Loading

@srikanthccv srikanthccv mentioned this pull request Oct 10, 2024
Closed
@srikanthccv srikanthccv marked this pull request as ready for review October 10, 2024 13:18
nityanandagohain
nityanandagohain previously approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't have much context, approving this to unblock.

Also do note that usage is not present here so when switching to v2, you will need to add the changes for reporting use.

@srikanthccv
Copy link
Member Author

@nityanandagohain, yes, it was a deliberate choice because there is no way to suppress the usage from one exporter. When we completely deprecate the old, then we will switch the usage.

@srikanthccv srikanthccv mentioned this pull request Oct 14, 2024
Open
@srikanthccv srikanthccv merged commit ae01b88 into main Oct 14, 2024
3 checks passed
@srikanthccv srikanthccv deleted the clickhousemetricswrite-v2 branch October 14, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivanshuraj1333 shivanshuraj1333 shivanshuraj1333 approved these changes

@nityanandagohain nityanandagohain Awaiting requested review from nityanandagohain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@srikanthccv @shivanshuraj1333 @nityanandagohain