Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add elasticsearch monitoring db #86

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

afzal442
Copy link

@afzal442 afzal442 commented Oct 7, 2024

Added elasticsearch monitoring dashboard

/claim #6010

@afzal442 afzal442 changed the title [WIP]feat: add elasticsearch monitoring db feat: add elasticsearch monitoring db Oct 18, 2024
@afzal442
Copy link
Author

hi @makeavish could you review it as to what we had a discussion on slack?

@makeavish
Copy link
Member

  • Make sure use correct Units for each panel
  • Check if dashboard variable is added to WHERE clause
  • Use IN operator if multiple values of variable is possible
  • Use = operator if only single value is possible
  • Read through metrics and aggregations doc: https://signoz.io/docs/metrics-management/types-and-aggregation/
  • Panel description should be present
  • Use LEGEND if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants