New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change usage of UnitName() to GetUnitName() #963

Merged

Sidoine merged 1 commit into Sidoine:master from johnnylam88:fix/use-getunitname

Aug 12, 2021

Contributor

johnnylam88 commented Aug 11, 2021

This avoids needing to do the name-realm dance to get the correct
name of the unit.


          fix: change usage of UnitName() to GetUnitName()

This avoids needing to do the name-realm dance to get the correct
name of the unit.

Contributor Author

johnnylam88 commented Aug 11, 2021

This pullup does depend on #958 and has some conflicts with #961 since they both touch src/engine/guid.ts.

Sidoine merged commit c4c394d into Sidoine:master

johnnylam88 deleted the fix/use-getunitname branch

August 12, 2021 23:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet