feat(runeforge): allow using runeforge power IDs in scripts #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using legendary bonus IDs in scripts, allow using the runeforge power IDs to identify equipped runeforge powers. The
EquippedRuneforge()script condition checks that the given id is either a legendary bonus ID or a runeforge power ID.A future update should probably remove the use of legendary bonus IDs. They are fragile and not necessarily computed correctly because we have to make the assumption that the first bonus ID on a piece of equipment is the legendary bonus ID, and this is not documented anywhere and will probably break in a future patch. The runeforge power ID is always correct and we query it using the documented API.
The default scripts should be changed to use runeforge power IDs instead of the legendary bonus IDs, but that's an
importsimcissue that I won't touch for now.