fix: ensure that we never have negative values for soul fragment counts #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `math.max` and `math.min` to express limits instead of inlining computations and add a check to enforce that `pending` can never be negative. Refactor the code slightly to extract a function to update `this.current.count` to be called whenever `count` or `pending` has changed, instead of duplicating the same code three times, and enforce limits appropriately in the new function.
Spend Soul Fragments first and then gain Soul Fragments afterwards in case we have a spell that spends the fragments but refunds some portion of them once they are spent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.