Skip to content

Conversation

@Sidnioulz
Copy link
Owner

This branch extends API support for creating and search directives and attributes. As part of that work, ForNode/ForDirective was heavily normalised through compiler transforms, leading to an AST now distinct from that produced by Vue 3's SFC compiler.

Work to do:

  • createAttribute (already done before)
  • createDirective
  • Typed utilities for individual directives
  • ForNode normalisation
  • Attribute creation unit tests
  • Directive creation unit tests
  • ForDirective unit tests
  • ForNode unit tests (:construction:)
  • Other relevant API unit tests (:construction:)
  • Documentation for ForDirective and ForNode changes

@Sidnioulz Sidnioulz added the enhancement New feature or request label Oct 2, 2023
@Sidnioulz Sidnioulz added this to the v1 milestone Oct 2, 2023
@Sidnioulz Sidnioulz self-assigned this Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: Patch coverage is 82.78041% with 109 lines in your changes missing coverage. Please review.

Project coverage is 81.23%. Comparing base (6eec7c8) to head (7462d81).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/template/api.ts 82.64% 62 Missing and 1 partial ⚠️
src/shims/compiler-core.d.ts 0.00% 24 Missing ⚠️
src/template/stringify.ts 87.71% 14 Missing ⚠️
src/template/utils.ts 90.62% 3 Missing ⚠️
src/transformTemplate.ts 70.00% 3 Missing ⚠️
src/template/compile.ts 97.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   78.47%   81.23%   +2.76%     
==========================================
  Files          20       22       +2     
  Lines        1468     1993     +525     
  Branches      162      215      +53     
==========================================
+ Hits         1152     1619     +467     
- Misses        313      369      +56     
- Partials        3        5       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidnioulz Sidnioulz force-pushed the temp/api-extension-and-vfor branch from 9bef4ac to 92221ef Compare February 17, 2025 13:22
@Sidnioulz Sidnioulz force-pushed the temp/api-extension-and-vfor branch from 92221ef to edf5b64 Compare February 17, 2025 14:09
@Sidnioulz Sidnioulz merged commit 6626fda into main Feb 17, 2025
9 checks passed
@Sidnioulz Sidnioulz deleted the temp/api-extension-and-vfor branch February 17, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants