-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytest 8.2.0 errors #8756
Pytest 8.2.0 errors #8756
Conversation
WalkthroughThe recent update in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Seriously anybody still got a Popcorn Hour 200 series? It's like a 2011 media player. Should just deprecate this one. |
Instead of blocking pytest8.2.0, why not add the setter? Under @attribute
def is_active(self): ... Add something like @is_active.setter
def is_active(self, value):
self.active = value |
added to Develop via |
I still want this fix, we don't want to block pytest 8.2.0, we want to fix the error (can't setattr to properties that don't have setters in testing, which is a good thing) |
Per pytest-dev/pytest#12263
Work around to avoid
AttributeError: property 'is_active' of 'Provider' object has no setter
in test_snatch.
Plus ignore the
Warning
abouttelnetlib
whilst looking why the build system was erroring