Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest 8.2.0 errors #8756

Closed
wants to merge 2 commits into from
Closed

Pytest 8.2.0 errors #8756

wants to merge 2 commits into from

Conversation

BKSteve
Copy link
Collaborator

@BKSteve BKSteve commented May 1, 2024

Per pytest-dev/pytest#12263

Work around to avoid AttributeError: property 'is_active' of 'Provider' object has no setter
in test_snatch.

Plus ignore the Warning about telnetlib whilst looking why the build system was erroring

Copy link
Contributor

coderabbitai bot commented May 1, 2024

Walkthrough

The recent update in pyproject.toml mainly focuses on refining the dependency management and warning settings for pytest. It specifically excludes a problematic version of pytest and introduces a new rule to suppress certain deprecation warnings, enhancing the project's stability and cleanliness in test outputs.

Changes

File Change Summary
pyproject.toml Updated pytest version constraint to exclude version 8.2.0 and added a new filter to ignore specific deprecation warnings.

🐇✨
A tiny tweak here, a small fix there,
Code flows smooth, with lesser despair.
Ignore the old, as warnings fade,
In the code garden, where peace is made.
Hop, hop, hooray, for a cleaner day! 🌟
🐰


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@BKSteve
Copy link
Collaborator Author

BKSteve commented May 1, 2024

Seriously anybody still got a Popcorn Hour 200 series? It's like a 2011 media player.

Should just deprecate this one.

@miigotu
Copy link
Contributor

miigotu commented May 12, 2024

Instead of blocking pytest8.2.0, why not add the setter?

Under

@attribute
def is_active(self): ...

Add something like

@is_active.setter
def is_active(self, value):
    self.active = value

@BKSteve
Copy link
Collaborator Author

BKSteve commented May 12, 2024

added to Develop via guess2 merge.
Closed

@BKSteve BKSteve closed this May 12, 2024
@BKSteve BKSteve deleted the pytest_8.2.0 branch May 12, 2024 13:32
@miigotu
Copy link
Contributor

miigotu commented May 12, 2024

Instead of blocking pytest8.2.0, why not add the setter?

Under

@attribute
def is_active(self): ...

Add something like

@is_active.setter
def is_active(self, value):
    self.active = value

I still want this fix, we don't want to block pytest 8.2.0, we want to fix the error (can't setattr to properties that don't have setters in testing, which is a good thing)

@BKSteve BKSteve mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants