-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS SDK #72
base: master
Are you sure you want to change the base?
JS SDK #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks pretty good to me. I'll leave it to devs more experience in JS to determine whether this feels 'native' though :P
sia_js/Cargo.toml
Outdated
|
||
[features] | ||
default = [] | ||
test_in_browser = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this. Doesn't seem very nice to require our lib to expose a feature just for testing. Maybe we can get away with using the WASM_BINDGEN_USE_BROWSER
environment variable somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷🏻
2f06e05
to
040e286
Compare
Draft of a potential JS sdk in Rust. There's a lot not to like in here, but there may be some things that are okay. As far as I can tell there is no easy way to unify the browser and nodejs packages in Rust.