Prioritize peers that support V2 RPCs in the sync loop #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tbh I don't remember exactly why I added that. One reason is that syncing can take a while, so your peer set will likely change by the time you're done. But even then, I don't see much downside to trying all of them. |
lukechampine
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prioritizes peers that support V2 RPCs so we can make use of
MaxSendBlocksmore often, v1 peers useMaxCatchUpBlockswhich was set to 10 so we sync in batches of only 10 blocks. I kept the 3-peer-cutoff even though I'm not sure why we have that, cc @lukechampine could you explain why that's necessary (or better)?