Support partial reads in ephemeral host #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
n8mgr
force-pushed
the
nate/host-proofs
branch
from
da9e890 to
59c9939
Compare
n8mgr
requested review from
ChrisSchinnerl,
Copilot,
lukechampine and
peterjan
There was a problem hiding this comment.
Pull request overview
This PR adds support for partial sector reads in the ephemeral host test utility by implementing proper validation and proof generation for arbitrary offset/length reads within sectors. Key changes include updating the go.sia.tech/core dependency to v0.19.0, refactoring the ReadSector method to use new sector subtree APIs, and increasing QUIC stream capacity.
- Updated
ReadSectorto support partial reads with validation and proper Merkle proof generation - Upgraded
go.sia.tech/corefrom pre-release to v0.19.0 - Replaced deprecated
golang.org/x/net/contextwith standardcontextpackage - Increased QUIC
MaxIncomingStreamsfrom 1000 to 1e6 to support higher concurrency
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| testutil/proofs.go | Replaced deprecated context import with standard library |
| testutil/host.go | Added validation and updated ReadSector to support partial reads with proper proof generation |
| rhp/v4/quic/quic.go | Increased MaxIncomingStreams to 1e6 for higher concurrency |
| go.mod | Updated core dependency to v0.19.0, moved golang.org/x/net to indirect |
| go.sum | Updated checksums for dependency changes |
| .changeset/updated_ephemeral_host_to_support_partial_reads.md | Added changeset documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
n8mgr
force-pushed
the
nate/host-proofs
branch
from
59c9939 to
38c9bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SiaFoundation/core#374