syncer: Return error from Connect if Syncer is closed #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good. Any chance other exposed methods would cause similar issues? Or is it just connect since it creates a new outgoing connection? |
peterjan
reviewed
Jan 17, 2025
peterjan
reviewed
Jan 17, 2025
peterjan
reviewed
Jan 17, 2025
n8maninger
force-pushed
the
syncer-close
branch
from
938562e to
2fee7e1
Compare
ChrisSchinnerl
force-pushed
the
syncer-close
branch
from
8531d91 to
c964e2e
Compare
ChrisSchinnerl
force-pushed
the
syncer-close
branch
from
c964e2e to
13022b2
Compare
peterjan
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100