Avoid locking when interacting with the database #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue this solves is the order in which we acquire the
muon the wallet and the locking of the database.Sometimes we start a db transaction which performs its own locking and then acquire
muand sometimes we acquiremuand then start a db transaction. Which can cause deadlocks for as long as the db transaction hasn't timed out yet.To fix this the PR refactors the code a bit to make sure we don't hold
muwhen using the database while allowing to acquiremuwhen we are already within a db transaction.UPDATE: This branch was run against the renterd CI which ran in a loop. It seems to have fixed the issue of
TestConsensusResyncsometimes taking minutes to complete. Instead if consistently finishes in 14-15s.