types: Simplify SatisfiedPolicy encoding #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8mgr
approved these changes
Nov 18, 2024
Member
Author
|
(this will break existing consensus.dbs, btw... rip) |
Member
Only ones that have the hard fork activated, no? |
Member
Author
|
oh, true. phew |
Alrighttt
added a commit
to GLEECBTC/sia-rust
that referenced
this pull request
Nov 22, 2024
Alrighttt
added a commit
to GLEECBTC/sia-rust
that referenced
this pull request
Nov 22, 2024
Alrighttt
added a commit
to KomodoPlatform/sia-core
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used the policy itself to figure out how many signatures and preimages to expect. This saved two length prefixes (16 bytes), but it was annoying to implement, and also led to a vulnerability:
EncodeTopanicked when called with the wrong number of signatures or preimages, butUnmarshalJSONdid not validate these, so you could trigger a panic by causing a node to decode an invalidSpendPolicyas JSON and then encode it as binary.The modal satisfied policy is 1 pubkey + 1 signature, so ~100 bytes, making this a ~16% size increase. Not insignificant, but tolerable.
Note that we don't need any additional validation:
(SpendPolicy).Verifyalready checks for superfluous signatures and preimages.