Skip to content

Conversation

@n8mgr
Copy link
Member

@n8mgr n8mgr commented Oct 29, 2024

When working with these types the context is usually known. The prefixes make storing and comparing hex strings more difficult. Removes the prefixes from the all of the hex types except for UnlockKey and PublicKey.

@lukechampine
Copy link
Member

goodnight sweet prince. 😔 It was a promising idea, but in practice the costs outweighed the benefits.

@n8mgr n8mgr merged commit 9fe97b7 into master Oct 29, 2024
7 checks passed
@n8mgr n8mgr deleted the nate/remove-prefixes branch October 29, 2024 22:19
Alrighttt added a commit to GLEECBTC/sia-rust that referenced this pull request Nov 15, 2024


Prior to this change Hash256 was represented as "h:<32 byte hex string>"

It is now represented as a plain hex string with no prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants