[Flang] Coarray allocation/deallocation + basic intrinsics for coarrays by JDPailleux · Pull Request #7 · SiPearl/llvm-project

JDPailleux · 2026-02-10T14:01:00Z

This PR presents the work done to add support for coarray allocation and deallocation in Flang.
A first round of feedback/reviews will be carried out here before applying it in LLVM.
Several PRs will be opened later:

Allocation/deallocation
Intrinsics which will depend on the first (COSHAPE, LCOBOUND, UCOBOUND, IMAGE_INDEX, THIS_IMAGE with coarray argument).

The new operations in the MIF Dialect are as follows:

mif::AllocaCoarrayOp : Allocates a coarray using prif_allocate_coarray PRIF procedure
mif::AllocaOp : Allocate an allocatable component of a coarray derived type using prif_allocate PRIF procedure
mif::DeallocaCoarrayOp : Deallocates a coarray using prif_deallocate_coarray PRIF procedure
mif::DellocaOp : Deallocate memory previously allocated in prif_allocate using prif_deallocate PRIF procedure
mif::CoshapeOp, mif::LcoboundOp, mif::UcoboundOp and mif::ImageIndexOp are operations for these basic intrinsics for coarrays

- Adding lowering and operation in MIF Dialect for UCOBOUND, LCOBOUND, COSHAPE and IMAGE_INDEX - Adding support of coarray argument for THIS_IMAGE in MIF Dialect (and the lowering)

bonachea

Thanks for all the great work on this PR!
I'm very excited to see coarray support added to flang.

I've only started to skim the code, but I already have a number of questions and suggestions. I think it may also help to discuss some of this over video chat.

flang-rt/lib/runtime/coarray.cpp

flang/include/flang/Optimizer/Dialect/MIF/MIFOps.td

flang/lib/Optimizer/Transforms/MIFOpConversion.cpp

flang-rt/lib/runtime/coarray.cpp

flang/lib/Optimizer/Transforms/MIFOpConversion.cpp

flang/test/Fir/MIF/form_team.mlir

flang/include/flang/Optimizer/Dialect/MIF/MIFOps.td

Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

bonachea

Thanks for all the improvements!
Noted another related request.

flang/lib/Lower/Allocatable.cpp

flang/lib/Optimizer/Transforms/MIFOpConversion.cpp

Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

…or POINTER component(s)

bonachea

Thanks for all the improvements!

I believe you've resolved all the issues I noticed on a casual skim of the code. I have not tried build-testing the changes, but that can probably wait for the upstream PR.

…er. (llvm#181941) The progress event reporter has a thread that reports events every 250 millisecond. and is destroyed in its destructor. When in event reporter desctructor, the event reporter may have pending event but the call mutex is destroyed leading to the crash. Relevant stack trace from CI. ``` [2026-02-13T17:46:13.577Z] libc++abi: terminating due to uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument [2026-02-13T17:46:13.577Z] PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash report from ~/Library/Logs/DiagnosticReports/. [2026-02-13T17:46:13.577Z] #0 0x0000000102b6943c llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake-os-verficiation/lldb-build/bin/lldb-dap+0x10008943c) [2026-02-13T17:46:13.577Z] #1 0x0000000102b67368 llvm::sys::RunSignalHandlers() (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake-os-verficiation/lldb-build/bin/lldb-dap+0x100087368) [2026-02-13T17:46:13.577Z] #2 0x0000000102b69f20 SignalHandler(int, __siginfo*, void*) (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake-os-verficiation/lldb-build/bin/lldb-dap+0x100089f20) [2026-02-13T17:46:13.577Z] #3 0x000000018bbdb744 (/usr/lib/system/libsystem_platform.dylib+0x1804e3744) [2026-02-13T17:46:13.577Z] #4 0x000000018bbd1888 (/usr/lib/system/libsystem_pthread.dylib+0x1804d9888) [2026-02-13T17:46:13.577Z] #5 0x000000018bad6850 (/usr/lib/system/libsystem_c.dylib+0x1803de850) [2026-02-13T17:46:13.577Z] #6 0x000000018bb85858 (/usr/lib/libc++abi.dylib+0x18048d858) [2026-02-13T17:46:13.577Z] #7 0x000000018bb744bc (/usr/lib/libc++abi.dylib+0x18047c4bc) [2026-02-13T17:46:13.577Z] llvm#8 0x000000018b7a0424 (/usr/lib/libobjc.A.dylib+0x1800a8424) [2026-02-13T17:46:13.577Z] llvm#9 0x000000018bb84c2c (/usr/lib/libc++abi.dylib+0x18048cc2c) [2026-02-13T17:46:13.577Z] llvm#10 0x000000018bb88394 (/usr/lib/libc++abi.dylib+0x180490394) [2026-02-13T17:46:13.577Z] llvm#11 0x000000018bb8833c (/usr/lib/libc++abi.dylib+0x18049033c) [2026-02-13T17:46:13.577Z] llvm#12 0x000000018bb01b90 (/usr/lib/libc++.1.dylib+0x180409b90) [2026-02-13T17:46:13.577Z] llvm#13 0x000000018bb01b34 (/usr/lib/libc++.1.dylib+0x180409b34) [2026-02-13T17:46:13.577Z] llvm#14 0x000000018bb038a0 (/usr/lib/libc++.1.dylib+0x18040b8a0) [2026-02-13T17:46:13.577Z] llvm#15 0x0000000102b6fbac lldb_dap::DAP::Send(std::__1::variant<lldb_dap::protocol::Request, lldb_dap::protocol::Response, lldb_dap::protocol::Event> const&) (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake-os-verficiation/lldb-build/bin/lldb-dap+0x10008fbac) [2026-02-13T17:46:13.577Z] llvm#16 0x0000000102b6f890 lldb_dap::DAP::SendJSON(llvm::json::Value const&) (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake-os-verficiation/lldb-build/bin/lldb-dap+0x10008f890) [2026-02-13T17:46:13.577Z] llvm#17 0x0000000102b78788 std::__1::__function::__func<lldb_dap::DAP::DAP(lldb_dap::Log&, lldb_dap::ReplMode, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>, bool, llvm::StringRef, lldb_private::transport::JSONTransport<lldb_dap::ProtocolDescriptor>&, lldb_private::MainLoopPosix&)::$_0, std::__1::allocator<lldb_dap::DAP::DAP(lldb_dap::Log&, lldb_dap::ReplMode, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>, bool, llvm::StringRef, lldb_private::transport::JSONTransport<lldb_dap::ProtocolDescriptor>&, lldb_private::MainLoopPosix&)::$_0>, void (lldb_dap::ProgressEvent&)>::operator()(lldb_dap::ProgressEvent&) (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake-os-verficiation/lldb-build/bin/lldb-dap+0x100098788) [2026-02-13T17:46:13.577Z] llvm#18 0x0000000102b8939c lldb_dap::ProgressEventManager::ReportIfNeeded() (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake-os-verficiation/lldb-build/bin/lldb-dap+0x1000a939c) [2026-02-13T17:46:13.577Z] llvm#19 0x0000000102b8982c lldb_dap::ProgressEventReporter::ReportStartEvents() (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake-os-verficiation/lldb-build/bin/lldb-dap+0x1000a982c) [2026-02-13T17:46:13.577Z] llvm#20 0x0000000102b8a038 void* std::__1::__thread_proxy[abi:nn200100]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, lldb_dap::ProgressEventReporter::ProgressEventReporter(std::__1::function<void (lldb_dap::ProgressEvent&)>)::$_0>>(void*) (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake-os-verficiation/lldb-build/bin/lldb-dap+0x1000aa038) [2026-02-13T17:46:13.577Z] llvm#21 0x000000018bbd1c08 (/usr/lib/system/libsystem_pthread.dylib+0x1804d9c08) [2026-02-13T17:46:13.577Z] llvm#22 0x000000018bbccba8 (/usr/lib/system/libsystem_pthread.dylib+0x1804d4ba8) ``` rdar://170331108

JDPailleux added 2 commits February 10, 2026 14:39

[Flang] Adding lowering for the allocation and deallocation of coarrays

343ec63

[Flang] Adding support of intrinsics with coarray argument

0ea9102

- Adding lowering and operation in MIF Dialect for UCOBOUND, LCOBOUND, COSHAPE and IMAGE_INDEX - Adding support of coarray argument for THIS_IMAGE in MIF Dialect (and the lowering)

JDPailleux changed the title ~~Jdp/flang/mif coarray~~ [Flang] Coarray allocation/deallocation + basic intrinsics for coarrays Feb 10, 2026

bonachea suggested changes Feb 12, 2026

View reviewed changes

bonachea reviewed Feb 13, 2026

View reviewed changes

flang/include/flang/Optimizer/Dialect/MIF/MIFOps.td Outdated Show resolved Hide resolved

JDPailleux and others added 4 commits February 13, 2026 14:48

Update flang/include/flang/Optimizer/Dialect/MIF/MIFOps.td

11e989a

Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

Update flang-rt/lib/runtime/coarray.cpp

7151f59

Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

Update flang/lib/Optimizer/Transforms/MIFOpConversion.cpp

ca9fc37

Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

Applying Dan's comments

041af09

bonachea suggested changes Feb 14, 2026

View reviewed changes

flang/lib/Lower/Allocatable.cpp Outdated Show resolved Hide resolved

flang/lib/Optimizer/Transforms/MIFOpConversion.cpp Show resolved Hide resolved

JDPailleux and others added 2 commits February 16, 2026 13:24

Update flang/lib/Lower/Allocatable.cpp

5103d59

Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

Adding fir.corank attribute + Assertion for coarray with ALLOCATABLE …

9c9227b

…or POINTER component(s)

JDPailleux force-pushed the jdp/flang/mif-coarray branch from 4da2ec4 to 9c9227b Compare February 17, 2026 22:22

bonachea approved these changes Feb 18, 2026

View reviewed changes

JDPailleux merged commit 3b44fe9 into jdp/flang/mif-coarray-to-upstream Feb 18, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Flang] Coarray allocation/deallocation + basic intrinsics for coarrays#7

[Flang] Coarray allocation/deallocation + basic intrinsics for coarrays#7
JDPailleux merged 8 commits intojdp/flang/mif-coarray-to-upstreamfrom
jdp/flang/mif-coarray

JDPailleux commented Feb 10, 2026

Uh oh!

bonachea left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bonachea left a comment

Uh oh!

Uh oh!

Uh oh!

bonachea left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

JDPailleux commented Feb 10, 2026

Uh oh!

bonachea left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bonachea left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bonachea left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments