Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FaML function and tests #224

Merged
merged 1 commit into from
Oct 26, 2024
Merged

FaML function and tests #224

merged 1 commit into from
Oct 26, 2024

Conversation

lukasc-ubc
Copy link
Member

  • new PCell GSiP.FaML_Si_1550_BB, for a facet-attached micro-lens
  • new function SiEPIC.utils.layout.FaML_two() to create a facet-attached micro-lens array (two channels), with test labels
  • new layer BlackBox
  • new unit test for the function and PCell
  • fix WAVEGUIDES.xml, by adding DevRec layer to Strip waveguide

- new PCell GSiP.FaML_Si_1550_BB, for a facet-attached micro-lens
- new function SiEPIC.utils.layout.FaML_two() to create a facet-attached micro-lens array (two channels), with test labels
- new layer BlackBox
- new unit test for the function and PCell
- fix WAVEGUIDES.xml, by adding DevRec layer to Strip waveguide
@lukasc-ubc lukasc-ubc merged commit 97cbf32 into master Oct 26, 2024
5 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 21.53%. Comparing base (b259f4a) to head (678ec01).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
klayout_dot_config/python/SiEPIC/utils/layout.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   21.41%   21.53%   +0.11%     
==========================================
  Files          43       43              
  Lines       10988    11003      +15     
==========================================
+ Hits         2353     2369      +16     
+ Misses       8635     8634       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants