refactor: remove meilisearch and all dual write logic#27
Conversation
|
Warning Rate limit exceeded@Shunseii has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 0 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughRemoved Meilisearch and related deployment/config, deleted TRPC routers and many schemas, migrated schema imports to a local dictionary module, upgraded Zod to v4, added flashcard learning_steps, and replaced several TRPC mutations with React Query/local table mutations. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bahar-marketing | 3ac7f20 | Commit Preview URL | Dec 26 2025, 12:00 AM |
Deploying bahar with
|
| Latest commit: |
3ac7f20
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9411403d.bahar-5xu.pages.dev |
| Branch Preview URL: | https://chore-remove-meili-dual-writ.bahar-5xu.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsx (1)
199-211: Add error handling for the delete mutation.The delete operation lacks error handling—if
deleteDeckfails, the success toast still displays and the error goes unhandled. Wrap the mutation call in a try-catch block and show appropriate feedback to the user.As per coding guidelines, use try/catch blocks and structured error types for error handling.
🔎 Proposed fix to add error handling
<DropdownMenuItem onClick={async () => { - await deleteDeck({ id: deck.id }); - - toast({ - title: t`Deck successfully deleted!`, - description: t`The deck "${deck.name}" has been deleted.`, - }); + try { + await deleteDeck({ id: deck.id }); + + toast({ + title: t`Deck successfully deleted!`, + description: t`The deck "${deck.name}" has been deleted.`, + }); + } catch (error) { + toast({ + title: t`Failed to delete deck`, + description: t`An error occurred while deleting "${deck.name}". Please try again.`, + variant: "destructive", + }); + } }} className="cursor-pointer" >apps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsx (2)
48-65: Add cache invalidation after flashcard reset.The mutation successfully resets flashcards but doesn't invalidate any related queries. If there are any UI components displaying flashcard state on this page or elsewhere, they may show stale data after the reset.
🔎 Add cache invalidation
const { mutateAsync: resetFlashcard } = useMutation({ mutationFn: async ({ dictionary_entry_id, }: { dictionary_entry_id: string; }) => { await Promise.all([ flashcardsTable.reset.mutation({ dictionary_entry_id, direction: "forward", }), flashcardsTable.reset.mutation({ dictionary_entry_id, direction: "reverse", }), ]); }, + onSuccess: async () => { + await queryClient.invalidateQueries({ + queryKey: flashcardsTable.today.cacheOptions.queryKey, + }); + }, });
280-336: Add cache invalidation after dictionary entry update.After successfully updating the dictionary entry, the query cache is not invalidated. This could lead to stale data being displayed if the user navigates to other pages that show this entry.
🔎 Add cache invalidation after successful edit
const onSubmit: SubmitHandler<z.infer<typeof FormSchema>> = async (data) => { try { const root = data?.root ?.trim() ?.replace(/[\s,]+/g, "") ?.split(""); const tags = data?.tags?.map((tag) => tag.name) ?? []; const id = wordId; const input = (() => { if (data.type === "ism") { return { ...data, id, root, tags, morphology: { ism: data?.morphology?.ism }, }; } else if (data.type === "fi'l") { return { ...data, id, root, tags, morphology: { verb: data?.morphology?.verb }, }; } else { return { ...data, id, root, tags, morphology: undefined, }; } })(); await editDictionaryEntry({ id: input.id, updates: input }); + await queryClient.invalidateQueries({ + queryKey: [...dictionaryEntriesTable.entry.cacheOptions.queryKey, wordId], + }); + toast({ title: t`Successfully updated the word!`, description: t`The word has been updated.`, }); } catch (err) { if (err instanceof Error) { console.error(err.message); } toast({ title: t`Failed to update the word!`, description: t`There was an error updating your word. Please try again.`, variant: "destructive", }); } };
🧹 Nitpick comments (4)
turbo.json (1)
4-4: Consider moving this unrelated change to a separate PR.The addition of
"ui": "stream"enables real-time log streaming in Turborepo, which is a developer experience improvement. However, this change is unrelated to the PR's objective of removing Meilisearch infrastructure and dual write logic. Consider either:
- Moving this to a separate PR for better change tracking
- Adding a note in the PR description explaining this DX improvement
apps/api/README.md (1)
106-112: Consider automating the manual migration seeding process.Steps 6–7 require users to manually copy SQL files, strip markers, and insert records into the migrations table. This is error-prone and difficult to maintain. Consider one of the following:
- Create a helper script (e.g.,
seed-user-migrations.ts) to automate this process.- Provide a migration runner that handles this on first user login.
- If this remains manual, add a clear script or SQL template users can copy and execute directly.
This will reduce friction during local setup and minimize setup failures.
Makefile (1)
20-20: Consider adding conventional Makefile targets (optional).While not required, Makefiles conventionally include
all,clean, andtestphony targets for standardization. Given this appears to be a project-specific utility Makefile, these may not be necessary. However, consider:
all: Default target that could build everything needed for local developmentclean: Could replace or wrapdelete-local-datafor consistencytest: Could trigger the test suite if you want Make-based testing workflowsBased on static analysis hints.
apps/web/src/lib/schemas/dictionary.ts (1)
32-78: Consider type-specific morphology validation.The morphology structure allows both
ismandverbfields to be present simultaneously, regardless of thetypefield value. While this provides flexibility, it could lead to inconsistent data (e.g.,type: "ism"with populatedverbmorphology).Consider adding a refinement to validate that morphology matches the word type, or document that this flexibility is intentional.
🔎 Optional refinement for type-specific validation
export const FormSchema = z.object({ word: z.string().min(1), translation: z.string().min(1), definition: z.string().optional(), root: z.string().optional(), tags: z.array(z.object({ name: z.string() })).optional(), antonyms: z .array( z.object({ word: z.string(), }), ) .optional(), examples: z .array( z.object({ sentence: z.string(), context: z.string().optional(), translation: z.string().optional(), }), ) .optional(), type: z.enum(["ism", "fi'l", "harf", "expression"]).optional(), morphology: z .object({ ism: z .object({ singular: z.string().optional(), dual: z.string().optional(), plurals: z .array( z.object({ word: z.string(), details: z.string().optional() }), ) .optional(), gender: z.enum(["masculine", "feminine"]).optional(), inflection: z .enum(["indeclinable", "diptote", "triptote"]) .optional(), }) .optional(), verb: z .object({ huroof: z .array( z.object({ harf: z.string(), meaning: z.string().optional(), }), ) .optional(), past_tense: z.string().optional(), present_tense: z.string().optional(), active_participle: z.string().optional(), passive_participle: z.string().optional(), imperative: z.string().optional(), masadir: z .array( z.object({ word: z.string(), details: z.string().optional(), }), ) .optional(), form: z.string().optional(), form_arabic: z.string().optional(), }) .optional(), }) .optional(), -}); +}).refine( + (data) => { + if (data.type === "ism" && data.morphology?.verb) { + return false; + } + if (data.type === "fi'l" && data.morphology?.ism) { + return false; + } + if ((data.type === "harf" || data.type === "expression") && data.morphology) { + return false; + } + return true; + }, + { + message: "Morphology must match the word type", + } +);
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (75)
.github/workflows/deploy-search.yml.github/workflows/update-indexes.yml.gitignoreCLAUDE.mdMakefileapps/api/.example.envapps/api/README.mdapps/api/drizzle/0011_dazzling_jackal.sqlapps/api/drizzle/meta/0011_snapshot.jsonapps/api/drizzle/meta/_journal.jsonapps/api/package.jsonapps/api/scripts/README.mdapps/api/scripts/migrate-meilisearch-to-user-db.tsapps/api/scripts/migrate-settings-decks-to-user-db.tsapps/api/src/auth.tsapps/api/src/clients/meilisearch.tsapps/api/src/clients/turso.tsapps/api/src/db/schema/decks.tsapps/api/src/db/schema/settings.tsapps/api/src/dictionary.jsonapps/api/src/flashcard.jsonapps/api/src/index.tsapps/api/src/routers/decks.tsapps/api/src/routers/dictionary.tsapps/api/src/routers/flashcard.tsapps/api/src/routers/settings.tsapps/api/src/routers/tags.tsapps/api/src/schema.jsonapps/api/src/schemas/deck.schema.tsapps/api/src/schemas/dictionary.schema.tsapps/api/src/schemas/flashcard.schema.tsapps/api/src/schemas/index.tsapps/api/src/schemas/words.schema.tsapps/api/src/utils/config.tsapps/api/src/utils/error.tsapps/api/src/utils/index.tsapps/mobile/.example.envapps/mobile/package.jsonapps/mobile/src/app/(search)/(home)/add-word.tsxapps/mobile/src/app/(search)/(home)/edit-word/[id].tsxapps/mobile/src/components/flashcards/FlashcardReview.tsxapps/mobile/src/lib/schemas/dictionary.tsapps/search/Dockerfileapps/search/README.mdapps/search/config.tomlapps/search/example.envapps/search/fly.tomlapps/web/.example.envapps/web/Dockerfileapps/web/env.tsapps/web/package.jsonapps/web/src/components/features/decks/DeckDialogContent.tsxapps/web/src/components/features/dictionary/add/AdditionalDetailsFormSection.tsxapps/web/src/components/features/dictionary/add/BasicDetailsFormSection.tsxapps/web/src/components/features/dictionary/add/CategoryFormSection.tsxapps/web/src/components/features/dictionary/add/IsmMorphologyCardSection.tsxapps/web/src/components/features/dictionary/add/MorphologyFormSection.tsxapps/web/src/components/features/dictionary/add/TagsFormSection.tsxapps/web/src/components/features/dictionary/add/VerbMorphologyCardSection.tsxapps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/components/features/settings/FlashcardSettingsCardSection.tsxapps/web/src/lib/error.tsapps/web/src/lib/schemas/dictionary.tsapps/web/src/router.tsapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/add/route.lazy.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsxapps/web/src/routes/_authorized-layout/_app-layout/settings/route.lazy.tsxdocker-compose.prod.yamldocker-compose.yamlpackages/schemas/package.jsonpackages/schemas/src/index.tspackages/schemas/tsconfig.jsonscripts/update-indexes.shturbo.json
💤 Files with no reviewable changes (45)
- apps/api/src/clients/turso.ts
- apps/web/src/routes/_authorized-layout/_app-layout/settings/route.lazy.tsx
- apps/web/.example.env
- apps/search/README.md
- apps/api/src/schemas/index.ts
- apps/web/src/router.ts
- apps/mobile/.example.env
- apps/web/env.ts
- apps/api/src/schemas/dictionary.schema.ts
- apps/api/src/utils/error.ts
- apps/api/src/routers/settings.ts
- apps/api/src/schemas/flashcard.schema.ts
- apps/api/src/clients/meilisearch.ts
- apps/api/src/auth.ts
- packages/schemas/package.json
- packages/schemas/tsconfig.json
- apps/mobile/package.json
- apps/api/src/routers/dictionary.ts
- apps/api/src/utils/index.ts
- apps/api/scripts/migrate-meilisearch-to-user-db.ts
- apps/search/example.env
- apps/api/scripts/migrate-settings-decks-to-user-db.ts
- apps/api/src/routers/tags.ts
- apps/mobile/src/components/flashcards/FlashcardReview.tsx
- apps/api/src/routers/decks.ts
- apps/api/src/db/schema/settings.ts
- docker-compose.prod.yaml
- apps/api/scripts/README.md
- apps/search/config.toml
- apps/api/src/flashcard.json
- apps/api/src/schemas/words.schema.ts
- apps/web/Dockerfile
- docker-compose.yaml
- apps/api/src/db/schema/decks.ts
- apps/search/fly.toml
- apps/api/src/schema.json
- apps/search/Dockerfile
- .github/workflows/deploy-search.yml
- scripts/update-indexes.sh
- apps/api/src/utils/config.ts
- apps/api/src/routers/flashcard.ts
- packages/schemas/src/index.ts
- apps/api/src/schemas/deck.schema.ts
- apps/api/src/dictionary.json
- .github/workflows/update-indexes.yml
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx}: Use TypeScript with strict typing across entire codebase
Write self-documenting code and avoid overuse of comments
Error handling with try/catch blocks and structured error types
Component naming: PascalCase for components, camelCase for functions/variables
Files:
apps/mobile/src/app/(search)/(home)/edit-word/[id].tsxapps/web/src/components/features/dictionary/add/VerbMorphologyCardSection.tsxapps/mobile/src/lib/schemas/dictionary.tsapps/web/src/components/features/decks/DeckDialogContent.tsxapps/web/src/components/features/dictionary/add/TagsFormSection.tsxapps/web/src/components/features/dictionary/add/BasicDetailsFormSection.tsxapps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/components/features/dictionary/add/CategoryFormSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsxapps/web/src/components/features/dictionary/add/MorphologyFormSection.tsxapps/web/src/components/features/settings/FlashcardSettingsCardSection.tsxapps/web/src/lib/schemas/dictionary.tsapps/web/src/components/features/dictionary/add/AdditionalDetailsFormSection.tsxapps/mobile/src/app/(search)/(home)/add-word.tsxapps/web/src/lib/error.tsapps/api/src/index.tsapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/dictionary/add/IsmMorphologyCardSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/add/route.lazy.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Do not useanytype unless absolutely necessary in TypeScript
UseDisplayErrorclass for user-friendly error messages andResult<T, E>type for explicit error handling
Files:
apps/mobile/src/app/(search)/(home)/edit-word/[id].tsxapps/web/src/components/features/dictionary/add/VerbMorphologyCardSection.tsxapps/mobile/src/lib/schemas/dictionary.tsapps/web/src/components/features/decks/DeckDialogContent.tsxapps/web/src/components/features/dictionary/add/TagsFormSection.tsxapps/web/src/components/features/dictionary/add/BasicDetailsFormSection.tsxapps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/components/features/dictionary/add/CategoryFormSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsxapps/web/src/components/features/dictionary/add/MorphologyFormSection.tsxapps/web/src/components/features/settings/FlashcardSettingsCardSection.tsxapps/web/src/lib/schemas/dictionary.tsapps/web/src/components/features/dictionary/add/AdditionalDetailsFormSection.tsxapps/mobile/src/app/(search)/(home)/add-word.tsxapps/web/src/lib/error.tsapps/api/src/index.tsapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/dictionary/add/IsmMorphologyCardSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/add/route.lazy.tsx
**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{tsx,jsx}: React components use functional style with hooks
Prefer using jotai atoms over React Context for state management
Files:
apps/mobile/src/app/(search)/(home)/edit-word/[id].tsxapps/web/src/components/features/dictionary/add/VerbMorphologyCardSection.tsxapps/web/src/components/features/decks/DeckDialogContent.tsxapps/web/src/components/features/dictionary/add/TagsFormSection.tsxapps/web/src/components/features/dictionary/add/BasicDetailsFormSection.tsxapps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/components/features/dictionary/add/CategoryFormSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsxapps/web/src/components/features/dictionary/add/MorphologyFormSection.tsxapps/web/src/components/features/settings/FlashcardSettingsCardSection.tsxapps/web/src/components/features/dictionary/add/AdditionalDetailsFormSection.tsxapps/mobile/src/app/(search)/(home)/add-word.tsxapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/dictionary/add/IsmMorphologyCardSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/add/route.lazy.tsx
apps/mobile/**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/mobile/**/*.{tsx,jsx}: Mobile app uses UniWind (Tailwind for React Native) with Tailwind CSS v4 for styling
Mobile app uses Expo with file-based routing (Expo Router)
Files:
apps/mobile/src/app/(search)/(home)/edit-word/[id].tsxapps/mobile/src/app/(search)/(home)/add-word.tsx
apps/web/**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Web app uses Shadcn/UI components and Tailwind CSS v4 for styling, using the
cn()utility function for combining and conditionally applying Tailwind classes
Files:
apps/web/src/components/features/dictionary/add/VerbMorphologyCardSection.tsxapps/web/src/components/features/decks/DeckDialogContent.tsxapps/web/src/components/features/dictionary/add/TagsFormSection.tsxapps/web/src/components/features/dictionary/add/BasicDetailsFormSection.tsxapps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/components/features/dictionary/add/CategoryFormSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsxapps/web/src/components/features/dictionary/add/MorphologyFormSection.tsxapps/web/src/components/features/settings/FlashcardSettingsCardSection.tsxapps/web/src/components/features/dictionary/add/AdditionalDetailsFormSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/dictionary/add/IsmMorphologyCardSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/add/route.lazy.tsx
apps/web/**/*.{tsx,jsx,ts}
📄 CodeRabbit inference engine (CLAUDE.md)
Web app uses Tanstack Router for client-side routing
Files:
apps/web/src/components/features/dictionary/add/VerbMorphologyCardSection.tsxapps/web/src/components/features/decks/DeckDialogContent.tsxapps/web/src/components/features/dictionary/add/TagsFormSection.tsxapps/web/src/components/features/dictionary/add/BasicDetailsFormSection.tsxapps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/components/features/dictionary/add/CategoryFormSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsxapps/web/src/components/features/dictionary/add/MorphologyFormSection.tsxapps/web/src/components/features/settings/FlashcardSettingsCardSection.tsxapps/web/src/lib/schemas/dictionary.tsapps/web/src/components/features/dictionary/add/AdditionalDetailsFormSection.tsxapps/web/src/lib/error.tsapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/dictionary/add/IsmMorphologyCardSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/add/route.lazy.tsx
**/*.{ts,js}
📄 CodeRabbit inference engine (CLAUDE.md)
Use Drizzle ORM for database operations
Files:
apps/mobile/src/lib/schemas/dictionary.tsapps/web/src/lib/schemas/dictionary.tsapps/web/src/lib/error.tsapps/api/src/index.ts
🧠 Learnings (9)
📓 Common learnings
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201
Timestamp: 2025-11-27T06:02:25.941Z
Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.
📚 Learning: 2025-11-27T06:02:25.941Z
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201
Timestamp: 2025-11-27T06:02:25.941Z
Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.
Applied to files:
apps/web/src/components/features/decks/DeckDialogContent.tsxapps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsxapps/web/src/components/features/settings/FlashcardSettingsCardSection.tsxapps/api/src/index.tsapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/add/route.lazy.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/web/**/*.{tsx,jsx,ts} : Web app uses Tanstack Router for client-side routing
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsxapps/web/src/components/features/settings/FlashcardSettingsCardSection.tsxapps/api/src/index.tsapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/add/route.lazy.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to **/*.{tsx,jsx} : React components use functional style with hooks
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsxapps/web/src/components/features/settings/FlashcardSettingsCardSection.tsxapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/mobile/**/*.{tsx,jsx} : Mobile app uses Expo with file-based routing (Expo Router)
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/mobile/src/app/(search)/(home)/add-word.tsx
📚 Learning: 2025-11-30T06:57:48.510Z
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/lib/db/operations/settings.ts:15-21
Timestamp: 2025-11-30T06:57:48.510Z
Learning: In apps/web/src/lib/db/operations/settings.ts, the settings table is intentionally implemented as a de-facto singleton without schema-level enforcement. Multiple rows can exist due to initialization races, but all operations (SELECT without WHERE, UPDATE without WHERE) treat rows as synchronized and interchangeable. This is a conscious design decision where code clarity could be improved but functional correctness is maintained.
Applied to files:
apps/web/src/components/features/settings/FlashcardSettingsCardSection.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/web/**/*.{tsx,jsx} : Web app uses Shadcn/UI components and Tailwind CSS v4 for styling, using the `cn()` utility function for combining and conditionally applying Tailwind classes
Applied to files:
apps/web/src/components/features/settings/FlashcardSettingsCardSection.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to **/*.{ts,js} : Use Drizzle ORM for database operations
Applied to files:
CLAUDE.mdapps/api/README.md
📚 Learning: 2025-11-27T23:01:26.752Z
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: packages/drizzle-user-db-schemas/package.json:1-20
Timestamp: 2025-11-27T23:01:26.752Z
Learning: drizzle-zod0.5.1 has peer dependencies of "zod": "*" (accepts any version) and "drizzle-orm": ">=0.23.13". The zod wildcard peer dependency means any zod version is compatible with drizzle-zod0.5.1.
Applied to files:
apps/api/package.json
🧬 Code graph analysis (4)
apps/web/src/components/features/decks/DeckDialogContent.tsx (1)
apps/web/src/lib/db/operations/decks.ts (1)
deck(47-126)
apps/web/src/components/features/settings/FlashcardSettingsCardSection.tsx (3)
apps/mobile/src/app/(search)/settings.tsx (2)
updates(107-109)SettingsScreen(88-284)apps/web/src/lib/db/operations/settings.ts (1)
updates(41-87)apps/web/src/components/features/settings/AdminSettingsCardSection.tsx (1)
data(64-66)
apps/web/src/lib/error.ts (2)
apps/api/src/routers/dictionary.ts (2)
req(147-215)word(444-466)packages/schemas/src/dictionary.ts (1)
Inflection(3-7)
apps/web/src/components/features/dictionary/add/IsmMorphologyCardSection.tsx (1)
packages/schemas/src/dictionary.ts (1)
Inflection(3-7)
🪛 checkmake (0.2.2)
Makefile
[warning] 20-20: Missing required phony target "all"
(minphony)
[warning] 20-20: Missing required phony target "clean"
(minphony)
[warning] 20-20: Missing required phony target "test"
(minphony)
🪛 LanguageTool
apps/api/README.md
[grammar] ~99-~99: Use a hyphen to join words.
Context: ...ate a new user through the web app (sign up flow) 5. Manually convert the user t...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Workers Builds: bahar-marketing
- GitHub Check: Cloudflare Pages
🔇 Additional comments (39)
.gitignore (1)
11-12: Verify this change is intentional for the Meilisearch removal scope.The addition of
vite.config.ts.timestamp-*to ignore Vite build artifacts appears tangential to the main PR objective of removing Meilisearch and dual write logic. While the pattern itself is valid and won't cause issues, please confirm this is intentional cleanup discovered during refactoring or if it should be deferred to a separate chore PR.apps/api/README.md (2)
81-91: Clarify and verify the instruction sequence.The sequence starts dev servers before the local database. Typically the database should be running first to avoid connection errors when the API initializes. Verify that this order works as documented, or clarify whether users should start
make local-dbin a separate terminal before step 1.
1-143: Comprehensive update to local development documentation.The README effectively documents the removal of Meilisearch and the shift to local-first development. The addition of the "Setting Up a New User" section is helpful and aligns well with the PR's objective to simplify local setup. The updates to the dev commands and removal of the deprecated migration script reference are clean and correct.
apps/api/.example.env (2)
29-29: SENTRY_ENV is already properly integrated into the configuration schema and actively consumed in the codebase (defined with enum validation inapps/api/src/utils/config.tsand used inapps/api/instrument.mjsfor Sentry initialization). No action required.Likely an incorrect or invalid review comment.
15-15: Resend API integration is properly implemented. Email sending is fully migrated to use Resend (mail.ts), configuration is validated (config.ts), and no orphaned SendGrid references remain. Additionally, SENTRY_ENV is correctly configured across the API and web applications.apps/web/src/components/features/decks/DeckDialogContent.tsx (2)
114-130: LGTM! Clean migration from TRPC to React Query.The deck mutations have been successfully migrated from TRPC to direct database operations via React Query. Both
createDeckandupdateDeckproperly invalidate the decks list cache on success, ensuring UI consistency.Based on learnings, the TRPC backend API calls were temporary and this migration completes the planned architecture change.
154-194: LGTM! Solid error handling and user feedback.The form submission logic properly handles both create and update flows with:
- Correct mutation call signatures
- Comprehensive error handling with try/catch
- User-friendly toast notifications in both success and error cases
- Appropriate form reset behavior (only on create)
apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (2)
321-334: LGTM! Successful migration to server-first architecture.The flashcard update mutation has been simplified from dual-write/optimistic updates to a single server-side mutation with comprehensive cache invalidation. The strategy correctly invalidates:
flashcardsTable.today- refreshes the current review queueflashcardsTable.counts- updates queue countsdecksTable.list- refreshes deck statisticsThis architectural change prioritizes data consistency over immediate UI feedback, which is appropriate for this use case.
361-407: LGTM! Well-structured flashcard grading logic.The
executeGradefunction properly:
- Calculates FSRS scheduling data from the current card state
- Constructs the update payload with all necessary timestamp and state fields
- Provides immediate UI feedback by updating local state before the mutation
- Correctly includes
updateFlashcardin the dependency arrayThe balance between immediate UI updates (lines 398-399) and server mutation ensures a responsive user experience while maintaining data consistency.
apps/web/src/components/features/settings/FlashcardSettingsCardSection.tsx (2)
47-54: Successfully migrated from TRPC to react-query mutations.The migration correctly replaces the dual-write pattern with a single mutation that updates local state and invalidates queries. The pattern aligns with the broader refactoring objective.
119-135: LGTM — submission logic correctly simplified.The form submission now uses a single mutation call instead of parallel remote/local updates, reducing complexity while maintaining functionality. The dependency array is correctly updated.
apps/api/drizzle/meta/_journal.json (1)
82-88: LGTM!The journal entry is correctly formatted and consistent with existing migration entries.
apps/api/drizzle/meta/0011_snapshot.json (1)
1-488: LGTM!The snapshot correctly represents the database schema after dropping the
decksandsettingstables. All remaining tables (accounts, sessions, users, verifications, databases, migrations) have proper:
- Column definitions
- Foreign key constraints with appropriate cascade behavior
- Unique indexes where needed
apps/api/drizzle/0011_dazzling_jackal.sql (1)
1-2: Do not apply this migration. Thedecksandsettingstables are still actively used throughout the application and will cause runtime failures.The
deckstable is heavily integrated into both web and mobile apps with active CRUD operations in:
apps/web/src/lib/db/operations/decks.tsapps/mobile/src/lib/db/operations/decks.tsThe
settingstable stores flashcard user preferences and is referenced in:
apps/web/src/components/features/flashcards/QuestionSide.tsxapps/web/src/components/features/flashcards/AnswerSide.tsxapps/web/src/components/features/settings/FlashcardSettingsCardSection.tsxBoth tables have active schema definitions in
packages/drizzle-user-db-schemas/src/and are still exported for client use. Applying this migration will break flashcard functionality across the application. If this is intended as part of a larger refactoring, ensure the migration is coordinated with corresponding code changes and a proper data migration strategy.Also, add a trailing newline at the end of the file for POSIX compliance.
⛔ Skipped due to learnings
Learnt from: Shunseii Repo: Shunseii/bahar PR: 24 File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201 Timestamp: 2025-11-27T06:02:25.941Z Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.Learnt from: Shunseii Repo: Shunseii/bahar PR: 24 File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201 Timestamp: 2025-11-27T06:02:25.941Z Learning: Decks are not considered critical data in the application, so data consistency issues with decks during rollback scenarios are acceptable.Learnt from: Shunseii Repo: Shunseii/bahar PR: 24 File: apps/web/src/lib/db/operations/settings.ts:15-21 Timestamp: 2025-11-30T06:57:48.510Z Learning: In apps/web/src/lib/db/operations/settings.ts, the settings table is intentionally implemented as a de-facto singleton without schema-level enforcement. Multiple rows can exist due to initialization races, but all operations (SELECT without WHERE, UPDATE without WHERE) treat rows as synchronized and interchangeable. This is a conscious design decision where code clarity could be improved but functional correctness is maintained.apps/mobile/src/lib/schemas/dictionary.ts (1)
78-78: LGTM! Standard formatting improvement.Adding a trailing newline at the end of the file aligns with common coding standards.
apps/web/src/lib/error.ts (1)
2-2: LGTM! Import migration aligns with schema consolidation.The import path change from
@bahar/schemasto the local@/lib/schemas/dictionaryaligns with the PR objective to consolidate schemas locally. The aliasing asDictionarySchemamaintains backward compatibility within this file.apps/web/package.json (2)
13-72: LGTM! Dependency removals align with Meilisearch removal.The removal of
@meilisearch/instant-meilisearch,react-instantsearch, and@bahar/schemasdependencies aligns perfectly with the PR objectives to remove Meilisearch infrastructure and consolidate schemas locally.
100-100: Update is compatible—no breaking changes detected in this codebase.The project uses wrangler minimally via the
wrangler pages devcommand. The wrangler.toml configuration contains no deprecated v3 features (no legacy_assets, node_compat, getBindingsProxy, etc.) and there are no programmatic wrangler API calls in the codebase. The upgrade to v4.54.0 is safe.apps/api/package.json (2)
12-12: LGTM! Simplified dev script and removed schema generation.The dev script simplification from the complex schema generation pipeline to
tsx watch srcaligns with the removal of Meilisearch-related schema tooling. This makes the development workflow cleaner.
56-56: LGTM! Correct placement of type definitions.Moving
@types/cookie-parserto devDependencies is the correct approach, as TypeScript type definitions are only needed at compile-time and should not be in production dependencies.apps/web/src/lib/schemas/dictionary.ts (2)
1-7: LGTM! Clean enum definition.The Inflection enum is well-defined with appropriate linguistic terminology for Arabic morphology.
9-31: LGTM! Well-structured basic fields.The basic field definitions are comprehensive with appropriate required/optional markings and validation constraints. The
typeenum values correctly represent Arabic grammatical categories.apps/web/src/routes/_authorized-layout/_app-layout/dictionary/edit/$wordId.tsx (2)
31-31: LGTM! Import migration aligns with schema consolidation.The import path change to the local dictionary schema is consistent with the broader schema migration in this PR.
119-166: LGTM! Delete flow appropriately simplified.The deletion flow correctly navigates away after the deletion, so no cache invalidation is needed. The home page will refetch fresh data on mount.
apps/web/src/components/features/dictionary/add/MorphologyFormSection.tsx (1)
16-16: LGTM! Consistent schema import migration.The import path change aligns with the schema consolidation across the codebase.
apps/mobile/src/app/(search)/(home)/add-word.tsx (1)
26-26: LGTM! Schema import migration completed.The import path change to the local dictionary schema completes the migration from the external
@bahar/schemaspackage. The mobile app now uses its local schema definition parallel to the web app.apps/web/src/components/features/dictionary/add/IsmMorphologyCardSection.tsx (1)
33-33: LGTM: Import path updated to local dictionary schema.The import source change from
@bahar/schemasto@/lib/schemas/dictionaryis part of the broader refactor to centralize dictionary schemas locally. This aligns with the PR's objective to remove external dependencies and consolidate schema definitions.apps/web/src/components/features/dictionary/add/VerbMorphologyCardSection.tsx (1)
21-21: LGTM: Import path updated consistently.The FormSchema import has been correctly updated to reference the local dictionary schema module, consistent with the broader refactor across dictionary components.
apps/mobile/src/app/(search)/(home)/edit-word/[id].tsx (1)
27-27: LGTM: Mobile app aligned with schema migration.The import path update mirrors the web app changes, ensuring consistent schema usage across platforms.
apps/web/src/components/features/dictionary/add/CategoryFormSection.tsx (1)
30-30: LGTM: Schema import updated correctly.The FormSchema import path change is consistent with the project-wide migration to local dictionary schemas.
apps/web/src/components/features/dictionary/add/AdditionalDetailsFormSection.tsx (1)
27-27: LGTM: Import path migrated successfully.The update to reference
@/lib/schemas/dictionarymaintains consistency with other form sections in the dictionary feature.apps/web/src/components/features/dictionary/add/TagsFormSection.tsx (1)
12-12: LGTM: Import source updated appropriately.The FormSchema import now correctly references the local dictionary schema module.
apps/web/src/components/features/dictionary/add/BasicDetailsFormSection.tsx (1)
13-13: LGTM: Schema import path updated.The FormSchema import change completes the migration pattern across all dictionary form sections.
apps/api/src/index.ts (2)
9-9: LGTM: Import streamlined after router removal.The import has been simplified to only include
getAllowedDomains, which is appropriate given the removal of the schema generation functionality.
31-34: All client-side references to removed routers have been properly updated.The removal of
dictionary,flashcard,tags,settings, anddecksrouters has been fully migrated in the client code. For example,DeckDialogContent.tsxnow usesdecksTable.create.mutationanddecksTable.update.mutation(local database operations) instead of the removedtrpc.decksendpoints. No remaining references to the removed routers were found in the codebase.CLAUDE.md (2)
107-141: Documentation updates align with architectural simplification.The removal of
@bahar/schemasfrom the shared packages list and the elimination of the dual-write note from the Writing Data section correctly reflect the PR's architectural changes. The documentation now accurately describes the simplified local-first data flow without the previous dual-write complexity.
52-75: Clear local development instructions with accurate multi-terminal workflow.The updated documentation provides a straightforward terminal-based development setup with correctly documented commands and ports. The API runs on port 3000 and web app on port 4000 as configured in their respective environment schemas. The local database (turso dev) and Drizzle Studio use their respective tool defaults (8080 and 4983), and all specified commands exist in the repository. The setup improves developer onboarding effectively.
apps/web/src/routes/_authorized-layout/_app-layout/dictionary/add/route.lazy.tsx (2)
30-30: The FormSchema import path change is correct and complete.The schema exists at the new location and is properly exported with comprehensive Zod validation. No lingering imports from the old
@bahar/schemaspackage remain in the codebase.
155-155: TheaddDictionaryEntryhook properly consolidates all necessary persistence operations.The removal of the dual-write pattern is complete and safe. The hook now handles all required data consistency:
- Local word storage via
addWordmutation- Automatic flashcard creation (forward and reverse)
- Search index updates via Orama
- Search state cleanup
No downstream code in the web app depends on the removed backend calls, and all data persistence is properly bundled in the single async call.
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
apps/web/src/lib/db/operations/flashcards.ts (3)
586-649: Critical: learning_steps not persisted in clearBacklog UPDATE.The
learning_stepsfield is read from the database (Line 603) and included in the FSRS Card, but the UPDATE statement (lines 612-641) doesn't persist it back. If the FSRS scheduler modifieslearning_stepsduring the repeat operation (Line 609), those changes will be lost.🔎 Proposed fix to include learning_steps in UPDATE
await db .prepare( `UPDATE flashcards SET due = ?, due_timestamp_ms = ?, last_review = ?, last_review_timestamp_ms = ?, state = ?, stability = ?, difficulty = ?, reps = ?, lapses = ?, elapsed_days = ?, - scheduled_days = ? + scheduled_days = ?, + learning_steps = ? WHERE id = ?`, ) .run([ newCard.due.toISOString(), newCard.due.getTime(), newCard.last_review?.toISOString() ?? null, newCard.last_review?.getTime() ?? null, newCard.state, newCard.stability, newCard.difficulty, newCard.reps, newCard.lapses, newCard.elapsed_days, newCard.scheduled_days, + newCard.learning_steps, rawCard.id, ]);
169-233: Major: learning_steps missing from create mutation.The
createmutation doesn't includelearning_stepsin the INSERT statement (lines 186-209), even though the schema defines it and theInsertFlashcardtype includes it. While the database default of 0 prevents errors, callers cannot set an initiallearning_stepsvalue.🔎 Proposed fix to add learning_steps to INSERT
await db .prepare( `INSERT INTO flashcards ( - id, dictionary_entry_id, difficulty, due, due_timestamp_ms, elapsed_days, - lapses, last_review, last_review_timestamp_ms, reps, scheduled_days, stability, state, direction, is_hidden - ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`, + id, dictionary_entry_id, difficulty, due, due_timestamp_ms, elapsed_days, + lapses, last_review, last_review_timestamp_ms, learning_steps, reps, scheduled_days, stability, state, direction, is_hidden + ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`, ) .run([ id, flashcard.dictionary_entry_id, flashcard.difficulty, flashcard.due, dueDateMs, flashcard.elapsed_days, flashcard.lapses, flashcard.last_review, lastReviewDateMs, + flashcard.learning_steps ?? 0, flashcard.reps, flashcard.scheduled_days, flashcard.stability, flashcard.state, flashcard.direction, 0, ]);
349-411: Major: learning_steps not reset in reset mutation.The
resetmutation resets all FSRS fields exceptlearning_steps(lines 363-383). For a complete reset,learning_stepsshould also be set back to 0.🔎 Proposed fix to reset learning_steps
await db .prepare( `UPDATE flashcards SET state = ?, difficulty = ?, stability = ?, reps = ?, lapses = ?, elapsed_days = ?, scheduled_days = ?, last_review = NULL, - last_review_timestamp_ms = NULL, due = ?, due_timestamp_ms = ? + last_review_timestamp_ms = NULL, learning_steps = ?, due = ?, due_timestamp_ms = ? WHERE dictionary_entry_id = ? AND direction = ?;`, ) .run([ FlashcardState.NEW, 0, 0, 0, 0, 0, 0, + 0, dueDate, dueDateMs, dictionary_entry_id, direction, ]);apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (2)
321-334: Add error handling to prevent data inconsistency.The mutation lacks an
onErrorhandler. Since the card is removed from the local UI state (line 386) before the mutation completes, a failure would result in the card disappearing from the review queue without being updated in the database.🔎 Recommended fix: Add error handler with rollback
const { mutateAsync: updateFlashcard } = useMutation({ mutationFn: flashcardsTable.update.mutation, onSuccess: () => { queryClient.invalidateQueries({ queryKey: flashcardsTable.today.cacheOptions.queryKey, }); queryClient.invalidateQueries({ queryKey: flashcardsTable.counts.cacheOptions.queryKey, }); queryClient.invalidateQueries({ queryKey: decksTable.list.cacheOptions.queryKey, }); }, + onError: (error) => { + // Rollback: re-add the card to the queue on error + if (currentCard) { + setCards((prev) => [currentCard, ...prev]); + } + // Show error to user (consider using DisplayError class per coding guidelines) + console.error('Failed to update flashcard:', error); + }, });Note: Consider using the
DisplayErrorclass mentioned in the coding guidelines for user-friendly error messages.
371-391: Addlearning_stepsto the update payload — it's computed by FSRS and must be persisted.The
learning_stepsfield is part of the FSRS Card type and tracks the current step in the card's learning/relearning sequence. Thef.repeat()algorithm computes an updated value for this field, but it's not included inlocalUpdates, so it won't be persisted to the database. This causes subsequent reviews to use stalelearning_stepsvalues, breaking the scheduler's short-term learning interval logic.Add to line 383:
learning_steps: selectedCard.learning_steps,
🧹 Nitpick comments (2)
apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (1)
371-383: Consider adding explicit typing forlocalUpdates.The
localUpdatesobject could benefit from an explicit type annotation to ensure type safety and catch any schema mismatches at compile time, aligning with the coding guideline for strict typing.Example with explicit typing
const localUpdates: Parameters<typeof flashcardsTable.update.mutation>[0]['updates'] = { due: selectedCard.due.toISOString(), due_timestamp_ms: dueTimestampMs, last_review: selectedCard?.last_review?.toISOString() ?? null, last_review_timestamp_ms: lastReviewTimestampMs, state: selectedCard.state, stability: selectedCard.stability, difficulty: selectedCard.difficulty, reps: selectedCard.reps, lapses: selectedCard.lapses, elapsed_days: selectedCard.elapsed_days, scheduled_days: selectedCard.scheduled_days, };This ensures compile-time verification that the updates match the expected schema.
As per coding guidelines for strict typing.
apps/mobile/src/utils/zod.ts (1)
1-46: Zod v4 migration implemented correctly.The error map migration follows the Zod v4 API correctly:
- Using
z.core.$ZodErrorMaptype- String-based issue codes (
"invalid_type","invalid_format", etc.)z.config({ customError: errorMap })for global configuration- Returning
undefinedfor unhandled casesThis error map is nearly identical to
apps/web/src/lib/zod.ts. Consider extracting to a shared package (e.g.,@bahar/zod-utils) to avoid drift between mobile and web implementations.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (27)
apps/api/drizzle/0012_conscious_rhodey.sqlapps/api/drizzle/meta/0012_snapshot.jsonapps/api/drizzle/meta/_journal.jsonapps/api/package.jsonapps/api/src/db/schema/auth.tsapps/api/src/utils/config.tsapps/mobile/package.jsonapps/mobile/src/app/(search)/(home)/add-word.tsxapps/mobile/src/app/(search)/(home)/edit-word/[id].tsxapps/mobile/src/utils/zod.tsapps/web/env.tsapps/web/package.jsonapps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/env.d.tsapps/web/src/lib/db/operations/flashcards.tsapps/web/src/lib/error.tsapps/web/src/lib/trpc.tsapps/web/src/lib/zod.tspackage.jsonpackages/db-operations/package.jsonpackages/drizzle-user-db-schemas/drizzle/0001_even_kitty_pryde.sqlpackages/drizzle-user-db-schemas/drizzle/meta/0001_snapshot.jsonpackages/drizzle-user-db-schemas/drizzle/meta/_journal.jsonpackages/drizzle-user-db-schemas/package.jsonpackages/drizzle-user-db-schemas/src/flashcards.tspackages/fsrs/package.jsonpackages/fsrs/src/index.ts
💤 Files with no reviewable changes (3)
- package.json
- apps/web/env.ts
- apps/web/src/env.d.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- apps/mobile/src/app/(search)/(home)/add-word.tsx
- apps/api/src/utils/config.ts
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx}: Use TypeScript with strict typing across entire codebase
Write self-documenting code and avoid overuse of comments
Error handling with try/catch blocks and structured error types
Component naming: PascalCase for components, camelCase for functions/variables
Files:
packages/drizzle-user-db-schemas/src/flashcards.tsapps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/mobile/src/app/(search)/(home)/edit-word/[id].tsxapps/web/src/lib/trpc.tspackages/fsrs/src/index.tsapps/web/src/lib/zod.tsapps/mobile/src/utils/zod.tsapps/web/src/lib/db/operations/flashcards.tsapps/api/src/db/schema/auth.tsapps/web/src/lib/error.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Do not useanytype unless absolutely necessary in TypeScript
UseDisplayErrorclass for user-friendly error messages andResult<T, E>type for explicit error handling
Files:
packages/drizzle-user-db-schemas/src/flashcards.tsapps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/mobile/src/app/(search)/(home)/edit-word/[id].tsxapps/web/src/lib/trpc.tspackages/fsrs/src/index.tsapps/web/src/lib/zod.tsapps/mobile/src/utils/zod.tsapps/web/src/lib/db/operations/flashcards.tsapps/api/src/db/schema/auth.tsapps/web/src/lib/error.ts
**/*.{ts,js}
📄 CodeRabbit inference engine (CLAUDE.md)
Use Drizzle ORM for database operations
Files:
packages/drizzle-user-db-schemas/src/flashcards.tsapps/web/src/lib/trpc.tspackages/fsrs/src/index.tsapps/web/src/lib/zod.tsapps/mobile/src/utils/zod.tsapps/web/src/lib/db/operations/flashcards.tsapps/api/src/db/schema/auth.tsapps/web/src/lib/error.ts
**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{tsx,jsx}: React components use functional style with hooks
Prefer using jotai atoms over React Context for state management
Files:
apps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/mobile/src/app/(search)/(home)/edit-word/[id].tsx
apps/web/**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Web app uses Shadcn/UI components and Tailwind CSS v4 for styling, using the
cn()utility function for combining and conditionally applying Tailwind classes
Files:
apps/web/src/components/features/flashcards/FlashcardDrawer.tsx
apps/web/**/*.{tsx,jsx,ts}
📄 CodeRabbit inference engine (CLAUDE.md)
Web app uses Tanstack Router for client-side routing
Files:
apps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/lib/trpc.tsapps/web/src/lib/zod.tsapps/web/src/lib/db/operations/flashcards.tsapps/web/src/lib/error.ts
apps/mobile/**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/mobile/**/*.{tsx,jsx}: Mobile app uses UniWind (Tailwind for React Native) with Tailwind CSS v4 for styling
Mobile app uses Expo with file-based routing (Expo Router)
Files:
apps/mobile/src/app/(search)/(home)/edit-word/[id].tsx
🧠 Learnings (10)
📓 Common learnings
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201
Timestamp: 2025-11-27T06:02:25.941Z
Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.
📚 Learning: 2025-11-27T23:01:26.752Z
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: packages/drizzle-user-db-schemas/package.json:1-20
Timestamp: 2025-11-27T23:01:26.752Z
Learning: drizzle-zod0.5.1 has peer dependencies of "zod": "*" (accepts any version) and "drizzle-orm": ">=0.23.13". The zod wildcard peer dependency means any zod version is compatible with drizzle-zod0.5.1.
Applied to files:
packages/fsrs/package.jsonpackages/db-operations/package.jsonapps/web/package.jsonpackages/drizzle-user-db-schemas/package.jsonapps/api/package.jsonapps/mobile/package.json
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to **/*.{ts,js} : Use Drizzle ORM for database operations
Applied to files:
packages/fsrs/package.jsonpackages/db-operations/package.jsonpackages/drizzle-user-db-schemas/package.jsonapps/api/src/db/schema/auth.ts
📚 Learning: 2025-11-27T06:02:25.941Z
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201
Timestamp: 2025-11-27T06:02:25.941Z
Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/web/src/lib/db/operations/flashcards.ts
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to **/*.{tsx,jsx} : React components use functional style with hooks
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/web/**/*.{tsx,jsx,ts} : Web app uses Tanstack Router for client-side routing
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/mobile/**/*.{tsx,jsx} : Mobile app uses Expo with file-based routing (Expo Router)
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer.tsxapps/mobile/package.json
📚 Learning: 2025-11-30T06:57:48.510Z
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/lib/db/operations/settings.ts:15-21
Timestamp: 2025-11-30T06:57:48.510Z
Learning: In apps/web/src/lib/db/operations/settings.ts, the settings table is intentionally implemented as a de-facto singleton without schema-level enforcement. Multiple rows can exist due to initialization races, but all operations (SELECT without WHERE, UPDATE without WHERE) treat rows as synchronized and interchangeable. This is a conscious design decision where code clarity could be improved but functional correctness is maintained.
Applied to files:
apps/api/src/db/schema/auth.ts
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/mobile/**/*.{tsx,jsx} : Mobile app uses UniWind (Tailwind for React Native) with Tailwind CSS v4 for styling
Applied to files:
apps/mobile/package.json
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/web/**/*.{tsx,jsx} : Web app uses Shadcn/UI components and Tailwind CSS v4 for styling, using the `cn()` utility function for combining and conditionally applying Tailwind classes
Applied to files:
apps/mobile/package.json
🧬 Code graph analysis (7)
apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (1)
apps/api/src/routers/flashcard.ts (2)
c(306-323)ctx(144-171)
packages/fsrs/src/index.ts (1)
apps/api/src/routers/flashcard.ts (3)
FlashcardState(13-18)c(306-323)flashcard(75-105)
apps/web/src/lib/zod.ts (2)
apps/mobile/src/utils/zod.ts (1)
errorMap(4-44)apps/marketing/src/i18n/index.ts (1)
t(11-13)
apps/mobile/src/utils/zod.ts (1)
apps/marketing/src/i18n/index.ts (1)
t(11-13)
apps/web/src/lib/db/operations/flashcards.ts (3)
apps/web/src/lib/db/operations/settings.ts (1)
updates(41-87)apps/web/src/lib/db/import/v1/index.ts (1)
createFlashcardStatement(82-136)apps/api/src/routers/flashcard.ts (1)
ctx(144-171)
apps/mobile/package.json (1)
apps/mobile/metro.config.js (1)
withMonorepoPaths(35-49)
apps/web/src/lib/error.ts (2)
apps/api/src/utils/error.ts (1)
ImportErrorCode(16-19)apps/api/src/routers/dictionary.ts (1)
req(147-215)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Workers Builds: bahar-marketing
- GitHub Check: Cloudflare Pages
🔇 Additional comments (33)
apps/api/drizzle/meta/_journal.json (1)
81-97: LGTM!The journal entries for migrations 0011 and 0012 are properly sequenced and formatted. This is standard Drizzle ORM migration tracking metadata.
apps/api/drizzle/meta/0012_snapshot.json (2)
450-464: Verify the intendedonDeletebehavior for the databases foreign key.The
databases.user_idFK usesonDelete: "no action"while similar FKs onaccountsandsessionsuseonDelete: "cascade". If a user is deleted, their database record will become orphaned rather than being cleaned up.If this is intentional (e.g., to preserve database resources for manual cleanup), this is fine. Otherwise, consider aligning with
cascade.
1-519: Schema snapshot looks well-structured.The snapshot properly reflects the schema state after migration 0012 with consistent timestamp handling, appropriate foreign keys, and sensible indexing. The removal of decks/settings tables aligns with the PR objective of removing Meilisearch dual-write logic.
apps/api/drizzle/0012_conscious_rhodey.sql (2)
1-13: Index drop/recreate pattern is correct for SQLite.Dropping indexes before column alterations and recreating them afterward is the appropriate approach for SQLite, which has limited ALTER TABLE support. The indexes are recreated with the same definitions before subsequent alterations.
14-20: Column alterations look correct.The timestamp columns are standardized to use millisecond-precision Unix timestamps, and the boolean-like columns (
email_verified,banned) properly use SQLite's integer representation with appropriate nullability.apps/api/src/db/schema/auth.ts (4)
1-2: LGTM!Imports are well-organized and all are utilized in the schema definitions below.
4-23: LGTM!The
userstable is well-structured with appropriate defaults fornotNullcolumns and consistent use oftimestamp_msmode for date fields.
77-93: LGTM!The
verificationstable is correctly structured with appropriate defaults for bothcreatedAtandupdatedAt, and an index onidentifierfor efficient lookups.
95-112: LGTM!Relations are correctly wired with proper field references matching the foreign key constraints defined in the tables.
apps/mobile/src/app/(search)/(home)/edit-word/[id].tsx (2)
27-27: The schema migration from@bahar/schemasto the local schema is complete.FormSchemais properly exported from@/lib/schemas/dictionary, and no remaining references to the old import path exist in the codebase.
38-38: The Zod v4 APIz.config({ customError: errorMap })is correct. The parameter name, global application, and syntax align with Zod v4 documentation. No changes needed.packages/drizzle-user-db-schemas/package.json (2)
13-14: Compatibility verified — drizzle-zod@0.8.3 officially supports zod@4.0.17.All package versions exist and are stable. The peer dependency for drizzle-zod@0.8.3 explicitly supports
zod: '^3.25.0 || ^4.0.0'and requiresdrizzle-orm: '>=0.36.0', both of which are satisfied by your versions (zod@4.0.17 and drizzle-orm@0.45.1).
18-18: No action needed. The drizzle-kit@0.31.8 update is compatible with drizzle-orm@0.45.1. Both packages are released in aligned cycles (early-mid December 2025) and designed to work together. drizzle-kit declares no conflicting peer dependencies.apps/web/src/lib/db/operations/flashcards.ts (1)
272-278: LGTM! learning_steps field properly integrated.The
learning_stepsfield is correctly added to the update logic following the same pattern as other FSRS fields.packages/drizzle-user-db-schemas/drizzle/0001_even_kitty_pryde.sql (1)
1-1: LGTM! Migration correctly adds learning_steps field.The migration properly adds the
learning_stepscolumn with an integer type and default value of 0, consistent with the schema definition.packages/drizzle-user-db-schemas/drizzle/meta/_journal.json (1)
11-18: LGTM! Journal entry correctly added.The new migration journal entry is properly structured and tracks the
0001_even_kitty_prydemigration.packages/drizzle-user-db-schemas/src/flashcards.ts (1)
33-33: LGTM! Schema correctly defines learning_steps field.The
learning_stepsfield is properly added to the flashcards schema with the correct type and default value, consistent with the migration.packages/drizzle-user-db-schemas/drizzle/meta/0001_snapshot.json (1)
215-222: LGTM! Snapshot correctly includes learning_steps.The snapshot metadata accurately reflects the
learning_stepscolumn definition with the correct type and default value.packages/fsrs/src/index.ts (3)
56-80: LGTM! fromFsrsCard correctly includes learning_steps.The
learning_stepsfield is properly mapped from the FSRS Card back to the database format (Line 73), consistent with the schema changes.
118-159: LGTM! gradeFlashcard correctly propagates learning_steps.The
learning_stepsfield is properly included in both the return type (Line 136) and the returned object (Line 157), ensuring it's preserved through the grading flow.
33-51: No action required—learning_stepsfield is valid in ts-fsrs@5.2.3.The
Cardtype from ts-fsrs@5.2.3 includes thelearning_stepsfield, which tracks the current step index during Learning or Relearning stages. The code correctly uses this field.apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (2)
71-71: LGTM: learning_steps field addition.The
learning_stepsfield is properly added with a sensible default value, following the same pattern as other optional FSRS fields.
393-393: LGTM: Dependency array is correct.The dependency array properly includes all values used within
executeGrade, andupdateFlashcardfromuseMutationis stable.packages/fsrs/package.json (1)
12-16: LGTM!The
ts-fsrsv5 upgrade is consistent with the same change inapps/mobileandapps/web, ensuring version alignment across the monorepo.apps/api/package.json (2)
12-14: Dev workflow simplified appropriately.The removal of
gen-schemafrom the dev script aligns with the PR objective of removing schema generation tooling tied to Meilisearch.
38-45: Jose v6 upgrade appears safe for this codebase.The upgrade to jose v6 is a major version bump with breaking changes (ESM-only, Node 18.x dropped, API changes). However, the codebase is already ESM-based (
"type": "module"), uses Node 20.11.1 (above v6's minimum), and only usesdecodeJwtfor simple JWT decoding inapps/api/src/utils/index.ts. ThedecodeJwtfunction remains compatible and the project doesn't use key generation, imports, or remote JWKS fetching—the areas most affected by jose v6 breaking changes.apps/web/src/lib/zod.ts (1)
1-48: Zod v4 migration implemented correctly.The implementation correctly follows Zod v4 conventions and exports the configured
zinstance for use throughout the web app.As noted in the mobile review, this error map is nearly identical to
apps/mobile/src/utils/zod.ts. Future consolidation into a shared package could reduce maintenance burden.apps/web/src/lib/error.ts (2)
2-3: Import changes align with PR objectives.The
DictionarySchemaimport moved from@bahar/schemasto local path, consistent with the removal of the shared schemas package. Thezod/v4import aligns with the monorepo-wide migration.
105-136: Zod v4 error structure correctly implemented.The changes correctly adapt to Zod v4's error codes and properties:
invalid_valuehandles enum/literal mismatches witherr.valuesinvalid_formatreplacesinvalid_stringfor string-format validation witherr.formaterr.inputis used for type validation checks (replacing v3'serr.received)- Standard properties (
err.expected,err.minimum,err.maximum) map correctly to error typespackages/db-operations/package.json (1)
11-17: Zod v4 upgrade is consistent across the monorepo.The pinned version (4.0.17) ensures consistency in both peerDependencies and devDependencies. All zod references in the monorepo are aligned to v4.0.17, including the consuming package apps/mobile.
apps/web/package.json (2)
60-71: drizzle-orm and ts-fsrs upgrades are safe and non-breaking.The
drizzle-ormupgrade to 0.45.1 contains only bug fixes and improvements with no breaking changes. The schemas throughout the codebase usingdrizzle-orm/sqlite-coreanddrizzle-zodremain fully compatible. Thets-fsrsupgrade to v5 is aligned with the broader refactoring in this PR.
99-99: Wrangler v4 upgrade is compatible with this project's deployment configuration.The minimal wrangler.toml uses no deprecated features (legacy assets, Workers Sites, legacy_env, getBindingsProxy) that would be affected by the v4 upgrade. Node.js v20.11.1 satisfies the v4 requirement (v18+). The Cloudflare Pages deployment is configured correctly with
pages_build_output_dir = "dist"and uses the correct local dev commandwrangler pages dev.apps/mobile/package.json (1)
71-73: Major version upgrade requires compatibility verification before merge.The
ts-fsrsv4→v5 upgrade is a significant version bump. The project doesn't publish a dedicated changelog, so breaking changes need to be verified by:
- Reviewing fsrs-rs v5 release notes for algorithm/API changes
- Checking actual usage of ts-fsrs in the codebase for parameter/signature compatibility
- Verifying Node.js runtime requirements haven't changed in ways that conflict with the project's CI/deployment environment
The
zodv3→v4 migration should also be verified for compatibility across the monorepo.
…ax for defining indexes
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsx (1)
199-211: Add error handling to prevent misleading success feedback.The delete operation lacks error handling. If the mutation fails, the success toast will still display, misleading users into thinking the deletion succeeded.
🔎 Proposed fix
<DropdownMenuItem onClick={async () => { - await deleteDeck({ id: deck.id }); - - toast({ - title: t`Deck successfully deleted!`, - description: t`The deck "${deck.name}" has been deleted.`, - }); + try { + await deleteDeck({ id: deck.id }); + + toast({ + title: t`Deck successfully deleted!`, + description: t`The deck "${deck.name}" has been deleted.`, + }); + } catch (error) { + toast({ + title: t`Failed to delete deck`, + description: t`An error occurred while deleting "${deck.name}". Please try again.`, + variant: "destructive", + }); + } }} className="cursor-pointer" >
🧹 Nitpick comments (5)
apps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsx (1)
10-10: Import path is correct; consider using barrel export for better maintainability.The FlashcardDrawer import has been properly updated and the new file structure exists with correct exports. However, both files importing FlashcardDrawer use the direct path
@/components/features/flashcards/FlashcardDrawer/FlashcardDrawerwhen a barrel export is available. Consider importing from@/components/features/flashcards/FlashcardDrawerinstead to align with typical module organization patterns and improve maintainability.apps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsx (1)
8-19: Add exhaustive return handling for type safety.The
getTranslatedTypefunction doesn't explicitly handle all possible paths. IfentryTypeisnullor doesn't match any case, the function returnsundefined, which could cause issues when rendered in JSX at line 36.🔎 Suggested improvements
Add an explicit return type and handle the null case:
-const getTranslatedType = (entryType: SelectDictionaryEntry["type"]) => { +const getTranslatedType = ( + entryType: SelectDictionaryEntry["type"] +): string | null => { + if (!entryType) return null; + switch (entryType) { case "ism": return t`Noun`; case "fi'l": return t`Verb`; case "harf": return t`Preposition`; case "expression": return t`Expression`; + default: + return null; } };Then update line 31 to check for null:
- {!!currentCard.dictionary_entry.type && ( + {!!currentCard.dictionary_entry.type && getTranslatedType(currentCard.dictionary_entry.type) && ( <Badge variant="secondary" className="w-max bg-primary/10 text-primary border-primary/20 hover:bg-primary/15 transition-colors" > {getTranslatedType(currentCard.dictionary_entry.type)} </Badge> )}apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts (1)
36-36: Fix typo in comment."represetnation" should be "representation".
🔎 Proposed fix
/** - * Converts the database represetnation of a flashcard to the format + * Converts the database representation of a flashcard to the format * expected by the fsrs library. */apps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsx (1)
25-84: Move feedbackConfig outside component to avoid recreation on every render.The
feedbackConfigobject is currently defined inside the component body, causing it to be recreated on every render. Since this configuration is static, it should be moved outside the component or memoized.🔎 Proposed fix
Move the configuration outside the component:
+const feedbackConfig = { + [Rating.Again]: { + icon: RotateCcw, + color: "text-muted-foreground", + bgColor: "bg-muted/20", + animation: { + initial: { scale: 0, rotate: 0 }, + animate: { + scale: [0, 1.2, 1], + rotate: [0, -10, 10, -10, 0], + }, + transition: { duration: 0.5 }, + }, + }, + [Rating.Hard]: { + icon: Brain, + color: "text-orange-500", + bgColor: "bg-orange-500/10", + animation: { + initial: { scale: 0 }, + animate: { + scale: [0, 1.3, 1], + opacity: [0, 1, 1], + }, + transition: { duration: 0.5, ease: "easeOut" }, + }, + }, + [Rating.Good]: { + icon: ThumbsUp, + color: "text-primary", + bgColor: "bg-primary/10", + animation: { + initial: { scale: 0, y: 10, opacity: 0 }, + animate: { + scale: 1, + y: 0, + opacity: 1, + }, + transition: { + duration: 0.4, + type: "spring", + stiffness: 200, + damping: 15, + }, + }, + }, + [Rating.Easy]: { + icon: Zap, + color: "text-green-500", + bgColor: "bg-green-500/10", + animation: { + initial: { scale: 0, rotate: -20 }, + animate: { + scale: [0, 1.4, 1], + rotate: [-20, 10, 0], + }, + transition: { duration: 0.4, ease: "easeOut" }, + }, + }, +}; + export const GradeFeedback: FC<{ grade: Grade | null; onComplete: () => void; }> = ({ grade, onComplete }) => { useEffect(() => { if (grade === null) return; const timer = setTimeout(onComplete, 600); return () => clearTimeout(timer); }, [grade, onComplete]); if (grade === null) return null; - const feedbackConfig = { - [Rating.Again]: { - icon: RotateCcw, - color: "text-muted-foreground", - bgColor: "bg-muted/20", - animation: { - initial: { scale: 0, rotate: 0 }, - animate: { - scale: [0, 1.2, 1], - rotate: [0, -10, 10, -10, 0], - }, - transition: { duration: 0.5 }, - }, - }, - [Rating.Hard]: { - icon: Brain, - color: "text-orange-500", - bgColor: "bg-orange-500/10", - animation: { - initial: { scale: 0 }, - animate: { - scale: [0, 1.3, 1], - opacity: [0, 1, 1], - }, - transition: { duration: 0.5, ease: "easeOut" }, - }, - }, - [Rating.Good]: { - icon: ThumbsUp, - color: "text-primary", - bgColor: "bg-primary/10", - animation: { - initial: { scale: 0, y: 10, opacity: 0 }, - animate: { - scale: 1, - y: 0, - opacity: 1, - }, - transition: { - duration: 0.4, - type: "spring", - stiffness: 200, - damping: 15, - }, - }, - }, - [Rating.Easy]: { - icon: Zap, - color: "text-green-500", - bgColor: "bg-green-500/10", - animation: { - initial: { scale: 0, rotate: -20 }, - animate: { - scale: [0, 1.4, 1], - rotate: [-20, 10, 0], - }, - transition: { duration: 0.4, ease: "easeOut" }, - }, - }, - }; const config = feedbackConfig[grade]; const Icon = config.icon;apps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsx (1)
67-68: Consider using actual locale from i18n for better flexibility.The locale is currently hardcoded based on text direction (rtl → "ar-u-nu-arab", ltr → "en"). While this works for the current use case, using the actual locale from
i18n.localewould be more flexible and accurate for date formatting.🔎 Proposed improvement
const dir = useDir(); -const locale = dir === "rtl" ? "ar-u-nu-arab" : "en"; +const { i18n } = useLingui(); +const locale = i18n.locale;This would require adding the import:
+import { useLingui } from "@lingui/react";Note: You may need to verify that
i18n.localereturns values compatible withIntlformatting functions used informatInterval.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (8)
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/index.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/utils.tsapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsx
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx}: Use TypeScript with strict typing across entire codebase
Write self-documenting code and avoid overuse of comments
Error handling with try/catch blocks and structured error types
Component naming: PascalCase for components, camelCase for functions/variables
Files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/utils.tsapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/index.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Do not useanytype unless absolutely necessary in TypeScript
UseDisplayErrorclass for user-friendly error messages andResult<T, E>type for explicit error handling
Files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/utils.tsapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/index.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{tsx,jsx}: React components use functional style with hooks
Prefer using jotai atoms over React Context for state management
Files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/index.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
apps/web/**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Web app uses Shadcn/UI components and Tailwind CSS v4 for styling, using the
cn()utility function for combining and conditionally applying Tailwind classes
Files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/index.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
apps/web/**/*.{tsx,jsx,ts}
📄 CodeRabbit inference engine (CLAUDE.md)
Web app uses Tanstack Router for client-side routing
Files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/utils.tsapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/index.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
**/*.{ts,js}
📄 CodeRabbit inference engine (CLAUDE.md)
Use Drizzle ORM for database operations
Files:
apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts
🧠 Learnings (7)
📓 Common learnings
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201
Timestamp: 2025-11-27T06:02:25.941Z
Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.
📚 Learning: 2025-11-27T06:02:25.941Z
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201
Timestamp: 2025-11-27T06:02:25.941Z
Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.
Applied to files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/index.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/web/**/*.{tsx,jsx,ts} : Web app uses Tanstack Router for client-side routing
Applied to files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to **/*.{tsx,jsx} : React components use functional style with hooks
Applied to files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/web/**/*.{tsx,jsx} : Web app uses Shadcn/UI components and Tailwind CSS v4 for styling, using the `cn()` utility function for combining and conditionally applying Tailwind classes
Applied to files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/mobile/**/*.{tsx,jsx} : Mobile app uses Expo with file-based routing (Expo Router)
Applied to files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/mobile/**/*.{tsx,jsx} : Mobile app uses UniWind (Tailwind for React Native) with Tailwind CSS v4 for styling
Applied to files:
apps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsx
🧬 Code graph analysis (7)
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsx (2)
apps/mobile/src/app/(search)/decks.tsx (2)
deleteMutation(247-247)deck(241-250)apps/web/src/components/features/decks/DeckDialogContent.tsx (4)
queryClient(119-123)deck(111-382)queryClient(135-139)queryClient(126-130)
apps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsx (2)
apps/marketing/src/i18n/index.ts (1)
t(11-13)apps/web/src/components/ui/badge.tsx (3)
Badge(36-36)Badge(30-34)BadgeProps(26-28)
apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts (4)
apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (2)
flashcard(59-76)dir(268-872)apps/api/src/routers/flashcard.ts (2)
c(306-323)flashcard(75-105)apps/web/src/lib/db/import/v1/index.ts (1)
createFlashcardStatement(82-136)apps/web/src/lib/db/operations/flashcards.ts (2)
days(37-37)flashcard(170-229)
apps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsx (3)
packages/fsrs/src/index.ts (2)
Grade(28-28)Rating(26-26)packages/design-system/src/utils.ts (1)
cn(4-6)apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (9)
useEffect(104-229)gradeCard(723-723)grade(456-464)gradeCard(787-787)grade(402-451)gradeCard(755-755)gradeCard(819-819)grade(105-110)fsrs(394-394)
apps/web/src/components/features/flashcards/FlashcardDrawer/index.tsx (1)
apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (5)
tag(249-263)FlashcardDrawerProps(91-97)flashcard(59-76)motion(233-266)data(386-390)
apps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsx (1)
apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (6)
fsrs(394-394)FlashcardDrawerProps(91-97)tag(249-263)motion(233-266)flashcard(59-76)grade(402-451)
apps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsx (3)
packages/fsrs/src/index.ts (1)
Rating(26-26)apps/web/src/hooks/useDir.ts (1)
useDir(4-10)apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts (1)
formatInterval(14-33)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Workers Builds: bahar-marketing
- GitHub Check: Cloudflare Pages
🔇 Additional comments (12)
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsx (1)
57-64: Clean migration from TRPC to React Query.The mutation setup correctly uses React Query's
useMutationand properly invalidates the deck list cache on success. The partial queryKey invalidation strategy will correctly clear all matching queries regardless of theshow_reverse_flashcardsparameter.apps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsx (1)
21-56: LGTM!The component properly handles optional fields with conditional rendering and optional chaining, and the staggered motion animations provide a nice UX touch.
apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts (1)
8-33: LGTM!The date formatting logic is clear and well-documented. The 60-day threshold for switching to exact dates is a reasonable UX choice.
apps/web/src/components/features/flashcards/FlashcardDrawer/index.tsx (1)
1-1: LGTM!Clean barrel export pattern for the refactored component.
apps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsx (2)
16-21: LGTM!The timer cleanup logic is properly implemented with useEffect cleanup function.
89-139: LGTM!The animation overlay implementation is well-structured with proper motion animations and the sparkles effect for the Easy rating adds a nice touch.
apps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsx (2)
34-65: LGTM!Using
useMemowith an empty dependency array for the static configuration is appropriate and prevents unnecessary recreations.
72-95: LGTM!The component structure is clean with proper typing, motion animations, and good use of the
cn()utility for conditional styling.apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx (4)
41-44: LGTM! Clean component modularization.The extraction of GradeOption, GradeFeedback, and TagBadgesList into separate components improves maintainability and follows good separation of concerns.
107-120: LGTM! Proper React Query mutation setup.The migration from TRPC to React Query's
useMutationis well-implemented with appropriate query invalidation in theonSuccesshandler.
137-142: LGTM! Improved naming and conversion logic.The renaming to
schedulingCards(camelCase) improves consistency, and the use of the extractedconvertFlashcardToFsrsCardutility reduces duplication.
428-439: LGTM! Cleaner grading UI with component mapping.Replacing the inline button blocks with a map over
GradeOptioncomponents significantly improves code readability and maintainability.
Shunseii
force-pushed
the
chore/remove-meili-dual-write
branch
from
445680e to
12c89dd
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsx (1)
57-64: Add error handling for delete operation.The delete mutation and its handler lack error handling. If the deletion fails, the user receives no feedback, creating a poor experience where clicking "Delete" appears to do nothing.
🔎 Recommended error handling implementation
Add an
onErrorhandler to the mutation:const { mutateAsync: deleteDeck } = useMutation({ mutationFn: decksTable.delete.mutation, onSuccess: async () => { await queryClient.invalidateQueries({ queryKey: decksTable.list.cacheOptions.queryKey, }); }, + onError: (error) => { + toast({ + title: t`Failed to delete deck`, + description: t`An error occurred while deleting the deck. Please try again.`, + variant: "destructive", + }); + }, });Alternatively, wrap the delete handler in a try-catch:
<DropdownMenuItem onClick={async () => { + try { await deleteDeck({ id: deck.id }); toast({ title: t`Deck successfully deleted!`, description: t`The deck "${deck.name}" has been deleted.`, }); + } catch (error) { + toast({ + title: t`Failed to delete deck`, + description: t`An error occurred while deleting the deck. Please try again.`, + variant: "destructive", + }); + } }} className="cursor-pointer" >Also applies to: 199-211
♻️ Duplicate comments (1)
apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts (1)
29-46: Code duplication already flagged in previous review.A previous review comment already identified that this conversion logic duplicates the
toFsrsCardfunction from@bahar/fsrs. Please refer to that comment for the recommended fix.
🧹 Nitpick comments (3)
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsx (1)
199-211: Consider adding loading state to prevent duplicate deletions.The delete button doesn't disable during the mutation, allowing rapid clicks to trigger multiple deletion attempts. While the backend should handle this safely, adding a loading state improves UX and prevents user confusion.
💡 Suggested implementation
Extract
isPendingfrom the mutation and disable the button during deletion:-const { mutateAsync: deleteDeck } = useMutation({ +const { mutateAsync: deleteDeck, isPending: isDeleting } = useMutation({ mutationFn: decksTable.delete.mutation, onSuccess: async () => { await queryClient.invalidateQueries({ queryKey: decksTable.list.cacheOptions.queryKey, }); }, });Then disable the dropdown item:
<DropdownMenuItem + disabled={isDeleting} onClick={async () => { await deleteDeck({ id: deck.id }); toast({ title: t`Deck successfully deleted!`, description: t`The deck "${deck.name}" has been deleted.`, }); }} className="cursor-pointer" > <Trans>Delete</Trans> </DropdownMenuItem>Note: Since multiple decks can be deleted independently, you may need to track pending state per deck ID using a Set or Map in state, rather than relying on the mutation's global
isPending.apps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsx (1)
8-19: Add explicit return type and consider a default case.The function lacks an explicit return type and a default case in the switch statement. While TypeScript's exhaustiveness checking may catch missing cases if the type is a strict union, adding an explicit return type improves clarity and a default case makes the code more defensive.
🔎 Proposed fix
-const getTranslatedType = (entryType: SelectDictionaryEntry["type"]) => { +const getTranslatedType = ( + entryType: SelectDictionaryEntry["type"] +): string => { switch (entryType) { case "ism": return t`Noun`; case "fi'l": return t`Verb`; case "harf": return t`Preposition`; case "expression": return t`Expression`; + default: + return entryType; } };apps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsx (1)
25-84: Consider movingfeedbackConfigoutside the component.The configuration object is static and doesn't depend on props or state, so it's recreated unnecessarily on every render. Moving it outside the component would provide a minor performance improvement.
🔎 Proposed refactor
Move the configuration above the component definition:
const feedbackConfig = { [Rating.Again]: { icon: RotateCcw, color: "text-muted-foreground", bgColor: "bg-muted/20", animation: { initial: { scale: 0, rotate: 0 }, animate: { scale: [0, 1.2, 1], rotate: [0, -10, 10, -10, 0], }, transition: { duration: 0.5 }, }, }, // ... rest of config } as const; export const GradeFeedback: FC<{ grade: Grade | null; onComplete: () => void; }> = ({ grade, onComplete }) => { // ... component body };
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (8)
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/index.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/utils.tsapps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
- apps/web/src/routes/_authorized-layout/_search-layout/index.lazy.tsx
- apps/web/src/components/features/flashcards/FlashcardDrawer/index.tsx
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx}: Use TypeScript with strict typing across entire codebase
Write self-documenting code and avoid overuse of comments
Error handling with try/catch blocks and structured error types
Component naming: PascalCase for components, camelCase for functions/variables
Files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Do not useanytype unless absolutely necessary in TypeScript
UseDisplayErrorclass for user-friendly error messages andResult<T, E>type for explicit error handling
Files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts
**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{tsx,jsx}: React components use functional style with hooks
Prefer using jotai atoms over React Context for state management
Files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
apps/web/**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Web app uses Shadcn/UI components and Tailwind CSS v4 for styling, using the
cn()utility function for combining and conditionally applying Tailwind classes
Files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
apps/web/**/*.{tsx,jsx,ts}
📄 CodeRabbit inference engine (CLAUDE.md)
Web app uses Tanstack Router for client-side routing
Files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts
**/*.{ts,js}
📄 CodeRabbit inference engine (CLAUDE.md)
Use Drizzle ORM for database operations
Files:
apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts
🧠 Learnings (6)
📓 Common learnings
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201
Timestamp: 2025-11-27T06:02:25.941Z
Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.
📚 Learning: 2025-11-27T06:02:25.941Z
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201
Timestamp: 2025-11-27T06:02:25.941Z
Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.
Applied to files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/web/**/*.{tsx,jsx,ts} : Web app uses Tanstack Router for client-side routing
Applied to files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to **/*.{tsx,jsx} : React components use functional style with hooks
Applied to files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/web/**/*.{tsx,jsx} : Web app uses Shadcn/UI components and Tailwind CSS v4 for styling, using the `cn()` utility function for combining and conditionally applying Tailwind classes
Applied to files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/mobile/**/*.{tsx,jsx} : Mobile app uses Expo with file-based routing (Expo Router)
Applied to files:
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsx
🧬 Code graph analysis (5)
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsx (2)
apps/mobile/src/app/(search)/decks.tsx (2)
deleteMutation(247-247)deck(241-250)apps/web/src/components/features/decks/DeckDialogContent.tsx (4)
queryClient(119-123)deck(111-382)queryClient(126-130)queryClient(135-139)
apps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsx (3)
packages/fsrs/src/index.ts (2)
Grade(28-28)Rating(26-26)packages/design-system/src/utils.ts (1)
cn(4-6)apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (5)
useEffect(104-229)grade(456-464)grade(402-451)grade(105-110)fsrs(394-394)
apps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsx (4)
packages/fsrs/src/index.ts (1)
Rating(26-26)apps/web/src/hooks/useDir.ts (1)
useDir(4-10)packages/design-system/src/utils.ts (1)
cn(4-6)apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts (1)
formatInterval(11-23)
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx (3)
apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts (1)
convertFlashcardToFsrsCard(29-47)packages/fsrs/src/index.ts (2)
Grade(28-28)Rating(26-26)apps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsx (1)
GradeOption(27-96)
apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts (1)
apps/web/src/components/features/flashcards/FlashcardDrawer.tsx (3)
flashcard(59-76)fsrs(394-394)grade(402-451)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Workers Builds: bahar-marketing
🔇 Additional comments (12)
apps/web/src/routes/_authorized-layout/_app-layout/decks/route.lazy.tsx (1)
31-31: LGTM: Import path updated correctly.The FlashcardDrawer import path has been updated to reflect the new subdirectory structure, and the usage throughout the file remains consistent.
apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts (1)
11-23: LGTM! Clean interval formatting logic.The function correctly handles same-day vs future date scenarios and properly uses locale-aware formatting.
apps/web/src/components/features/flashcards/FlashcardDrawer/TagBadgesList.tsx (1)
21-56: LGTM! Well-structured component with smooth animations.The component properly handles conditional rendering and implements staggered animations for a polished user experience.
apps/web/src/components/features/flashcards/FlashcardDrawer/GradeFeedback.tsx (2)
16-21: LGTM! Proper timer cleanup.The effect correctly manages the timer lifecycle and includes appropriate cleanup on unmount or dependency changes.
89-139: LGTM! Excellent animation implementation.The rendering logic is well-structured with smooth animations and the sparkle effect for "Easy" ratings adds a nice touch. The math for positioning sparkles in a circle is correct.
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx (4)
1-44: LGTM! Clean import organization.The imports are well-organized and the new modular components are properly imported.
134-145: LGTM! Improved consistency with camelCase naming.The rename from
scheduling_cardstoschedulingCardsfollows JavaScript naming conventions, and using the extractedconvertFlashcardToFsrsCardutility improves code organization.
147-180: LGTM! Grade execution logic is sound.The function correctly updates both local and remote state with proper scheduling data.
419-439: LGTM! Cleaner approach with mapped components.Mapping over the rating values to render
GradeOptioncomponents is more maintainable and DRY compared to manually coding each button. The refactoring improves code quality.apps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsx (3)
11-25: LGTM! Well-defined TypeScript types.The type definitions are clear and provide good type safety for the component.
34-65: LGTM! Proper use of useMemo for static configuration.The configuration is correctly memoized with an empty dependency array since it's static, preventing unnecessary recomputation.
67-96: LGTM! Clean component implementation with proper animations.The component correctly determines locale based on text direction and renders a well-structured button with smooth animations and formatted interval display.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx (1)
144-177: Addlearning_stepsto thelocalUpdatesobject.The
learning_stepsfield is missing from thelocalUpdatesobject. The reference implementation inpackages/fsrs/src/index.ts(gradeFlashcardfunction, line 157) includeslearning_steps: selectedCard.learning_stepsin the returned updates. This field should be persisted when saving the graded card.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
apps/web/package.jsonapps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsxapps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/web/src/components/features/flashcards/FlashcardDrawer/utils.ts
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx}: Use TypeScript with strict typing across entire codebase
Write self-documenting code and avoid overuse of comments
Error handling with try/catch blocks and structured error types
Component naming: PascalCase for components, camelCase for functions/variables
Files:
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Do not useanytype unless absolutely necessary in TypeScript
UseDisplayErrorclass for user-friendly error messages andResult<T, E>type for explicit error handling
Files:
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{tsx,jsx}: React components use functional style with hooks
Prefer using jotai atoms over React Context for state management
Files:
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
apps/web/**/*.{tsx,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Web app uses Shadcn/UI components and Tailwind CSS v4 for styling, using the
cn()utility function for combining and conditionally applying Tailwind classes
Files:
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
apps/web/**/*.{tsx,jsx,ts}
📄 CodeRabbit inference engine (CLAUDE.md)
Web app uses Tanstack Router for client-side routing
Files:
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
🧠 Learnings (6)
📓 Common learnings
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201
Timestamp: 2025-11-27T06:02:25.941Z
Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.
📚 Learning: 2025-11-27T23:01:26.752Z
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: packages/drizzle-user-db-schemas/package.json:1-20
Timestamp: 2025-11-27T23:01:26.752Z
Learning: drizzle-zod0.5.1 has peer dependencies of "zod": "*" (accepts any version) and "drizzle-orm": ">=0.23.13". The zod wildcard peer dependency means any zod version is compatible with drizzle-zod0.5.1.
Applied to files:
apps/web/package.json
📚 Learning: 2025-11-27T06:02:25.941Z
Learnt from: Shunseii
Repo: Shunseii/bahar PR: 24
File: apps/web/src/components/features/decks/DeckDialogContent.tsx:195-201
Timestamp: 2025-11-27T06:02:25.941Z
Learning: In apps/web/src/components/features/decks/DeckDialogContent.tsx, the backend API calls (trpc.decks.create and trpc.decks.update) are temporary and planned to be removed after migration is complete.
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/web/**/*.{tsx,jsx} : Web app uses Shadcn/UI components and Tailwind CSS v4 for styling, using the `cn()` utility function for combining and conditionally applying Tailwind classes
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to **/*.{tsx,jsx} : React components use functional style with hooks
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
📚 Learning: 2025-12-24T04:04:31.679Z
Learnt from: CR
Repo: Shunseii/bahar PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-24T04:04:31.679Z
Learning: Applies to apps/web/**/*.{tsx,jsx,ts} : Web app uses Tanstack Router for client-side routing
Applied to files:
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx
🧬 Code graph analysis (1)
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx (2)
packages/fsrs/src/index.ts (3)
toFsrsCard(33-51)Grade(28-28)Rating(26-26)apps/web/src/components/features/flashcards/FlashcardDrawer/GradeOption.tsx (1)
GradeOption(27-96)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Workers Builds: bahar-marketing
- GitHub Check: Cloudflare Pages
🔇 Additional comments (8)
apps/web/src/components/features/flashcards/FlashcardDrawer/FlashcardDrawer.tsx (6)
1-44: LGTM!The import refactoring is well-organized. The separation of concerns is clean with UI components extracted to their own modules (GradeOption, GradeFeedback, TagBadgesList), and the FSRS conversion logic properly imported from
@bahar/fsrs.
134-142: LGTM!The rename from
scheduling_cardstoschedulingCardsfollows JavaScript/TypeScript camelCase conventions, and the integration withtoFsrsCardfrom the external module is correct.
179-190: LGTM!The animation-based grading flow is clean - storing the callback reference and deferring execution until animation completes is a good pattern for UX.
107-120: LGTM!The migration from TRPC to local table mutations aligns with the PR objectives. Query invalidation is comprehensive, covering today's cards, counts, and deck lists. Based on learnings, this completes the planned removal of temporary backend API calls.
425-435: Clean refactor using array mapping.Replacing the explicit four-button block with a map over
Ratingvalues improves maintainability. Theas constassertion ensures type safety. This aligns with DRY principles.
219-227: LGTM!The extracted
GradeFeedbackcomponent integrates cleanly with theAnimatePresencewrapper, maintaining the same animation behavior while improving code organization.apps/web/package.json (2)
14-14: The Zod v4 upgrade is compatible with the package versions selected.@hookform/resolversv5.2.2 supports Zod v4 (added in v5.1.0), anddrizzle-ormv0.45.1 works with Zod v4 via the separatedrizzle-zodpackage (v0.8.3 in this repo, which supports Zod v4). The codebase has already been migrated to Zod v4 across all packages with no v3-specific patterns remaining.Likely an incorrect or invalid review comment.
69-69: No action needed – ts-fsrs v5 upgrade is properly implemented.The upgrade from ts-fsrs v4.5.1 to v5.2.3 has been correctly handled. The
enable_fuzzparameter used infsrs({ enable_fuzz: true })is valid in v5, and thelearning_stepsfield is properly mapped throughout the codebase (database schema, FSRS Card conversion, and grading logic). All breaking changes appear to be addressed.
1 participant
Summary by CodeRabbit
New Features
Removed Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.