Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylelint-scss to 6.3.2 #426

Merged
merged 7 commits into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/grumpy-lions-call.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/stylelint-plugin': major
---

Bumped all dependencies. Dropped support for sylelint@14 and stylelint@15
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"packages/*"
],
"scripts": {
"test": "jest",
"test": "NODE_OPTIONS=\"--experimental-vm-modules --no-warnings\" jest --runInBand",
"lint": "eslint '**/*.{js,jsx,ts,tsx}' && prettier './**/*.{md,json,yml}' --check",
"generate": "plop",
"generate:package": "plop package && yarn plop docs",
Expand Down
16 changes: 8 additions & 8 deletions packages/stylelint-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,18 @@
},
"homepage": "https://github.com/Shopify/web-configs/blob/main/packages/stylelint-plugin/README.md",
"dependencies": {
"postcss": "^8.4.21",
"postcss-scss": "^4.0.6",
"stylelint-order": "^6.0.3",
"stylelint-prettier": "^4.0.2",
"stylelint-scss": "^5.0.1"
"postcss": "^8.4.39",
"postcss-scss": "^4.0.9",
"stylelint-order": "^6.0.4",
"stylelint-prettier": "^5.0.0",
"stylelint-scss": "^6.3.2"
},
"peerDependencies": {
"stylelint": ">=15.0.0"
"stylelint": ">=16.0.0"
},
"devDependencies": {
"jest-preset-stylelint": "^4.2.0",
"jest-preset-stylelint": "^7.0.1",
"strip-ansi": "^6.0.0",
"stylelint": "^15.2.0"
"stylelint": "^16.6.1"
}
}
41 changes: 27 additions & 14 deletions packages/stylelint-plugin/tests/config-e2e.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,23 @@ describe('stylelint-plugin E2E Tests', () => {
const result = runStylelint('value-keyword-case.*.scss');

const expectedResult = `
Deprecation warnings:
- The "scss/at-import-no-partial-leading-underscore" rule is deprecated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix these dependency warnings by replacing our mention of scss/at-import-no-partial-leading-underscore with scss/load-no-partial-leading-underscore-

'scss/at-import-no-partial-leading-underscore': true,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- 'at-import-no-partial-leading-underscore' has been deprecated, and will be removed in '7.0'. Use 'load-no-partial-leading-underscore' instead. See: https://github.com/stylelint-scss/stylelint-scss/blob/v5.2.1/src/rules/at-import-no-partial-leading-underscore/README.md
- The "scss/at-import-partial-extension-blacklist" rule is deprecated.
- 'at-import-partial-extension-blacklist' has been deprecated, and will be removed in '7.0'. Use 'at-import-partial-extension-disallowed-list' instead. See: https://github.com/stylelint-scss/stylelint-scss/blob/v6.1.0/src/rules/at-import-partial-extension-blacklist/README.md

value-keyword-case.invalid.scss
1:7 ✖ Expected "Value" to be "value" value-keyword-case
2:7 ✖ Expected "VALUE" to be "value" value-keyword-case
5:10 ✖ Expected "Monaco" to be "monaco" value-keyword-case
6:18 ✖ Expected "Monaco" to be "monaco" value-keyword-case
1:7 ✖ Expected "Value" to be "value" value-keyword-case
2:7 ✖ Expected "VALUE" to be "value" value-keyword-case
5:10 ✖ Expected "Monaco" to be "monaco" value-keyword-case
6:18 ✖ Expected "Monaco" to be "monaco" value-keyword-case

4 problems (4 errors, 0 warnings)
`.trim();
✖ 4 problems (4 errors, 0 warnings)
4 errors potentially fixable with the "--fix" option.
`.trim();

expect(result.output).toStrictEqual(expectedResult);
expect(result.error).toStrictEqual(expectedResult);
expect(result.status).toBe(2);
});

Expand All @@ -35,16 +42,22 @@ value-keyword-case.invalid.scss
// trailing whitespace and editors really want to remove that trailing
// whitespace when saving the file
const expectedResult = `
Deprecation warnings:
- The "scss/at-import-no-partial-leading-underscore" rule is deprecated.
- 'at-import-no-partial-leading-underscore' has been deprecated, and will be removed in '7.0'. Use 'load-no-partial-leading-underscore' instead. See: https://github.com/stylelint-scss/stylelint-scss/blob/v5.2.1/src/rules/at-import-no-partial-leading-underscore/README.md
- The "scss/at-import-partial-extension-blacklist" rule is deprecated.
- 'at-import-partial-extension-blacklist' has been deprecated, and will be removed in '7.0'. Use 'at-import-partial-extension-disallowed-list' instead. See: https://github.com/stylelint-scss/stylelint-scss/blob/v6.1.0/src/rules/at-import-partial-extension-blacklist/README.md

scss.invalid.scss
6:5 ✖ Expected ".n1 .n2 .n3" to have no more than 2 classes selector-max-class
6:5 ✖ Expected ".n1 .n2 .n3" to have no more than 1 combinator selector-max-combinators
16:20 ✖ Expected "$value * 1px" instead of "#{$value}px". Consider writing "value" in terms of px originally. scss/dimension-no-non-numeric-values
22:3 ✖ Unexpected union class name with the parent selector (&) scss/selector-no-union-class-name
6:5 ✖ Expected ".n3" to have no more than 2 classes selector-max-class
6:5 ✖ Expected ".n3" to have no more than 1 combinator selector-max-combinators
16:12 ✖ Expected "$value * 1px" instead of "#{$value}px". Consider writing "value" in terms of px originally. scss/dimension-no-non-numeric-values
22:3 ✖ Unexpected union class name with the parent selector (&) scss/selector-no-union-class-name

4 problems (4 errors, 0 warnings)
`.trim();
4 problems (4 errors, 0 warnings)
`.trim();

expect(result.output).toStrictEqual(expectedResult);
expect(result.error).toStrictEqual(expectedResult);
expect(result.status).toBe(2);
});
});
Expand Down
Loading
Loading