-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade prettier plugins #397
Conversation
Can you also update the prettier versions in |
@@ -0,0 +1,5 @@ | |||
--- | |||
'@shopify/eslint-plugin': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier v3 has potential to change file output, and requires co-ordinating updating prettier within the source repo. I think this should be a major version bump.
Also if you're in the process of making breaking changes - |
92ff133
to
09fe3a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for wrangling the node bumps along the way, thanks to new version of execa that gets pulled in wanting node ^14.18.0 || ^16.14.0 || >=18.0.0
.
Jumping to 18.16 for the in-repo node version makes sense as that's the most recent LTS. We're still running CI against 14/16/18 and we don't force versions through our own engines fields.
changeset also upgrade prettier itself upgrade stylelint as well upgrade to major release wip split changelogs bump node version in dev wip
026e464
to
3895e25
Compare
Description
This PR upgrades prettier plugin versions so we can upgrade
web
's version to ^3