-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eslint plugin] Update polaris-no-bare-stack-item
and polaris-prefer-sectioned-prop
#371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
@laurkim / @kyledurand: Why is this this marked as a Even if this were to be changed so that it acted upon all of Card/Stack/LegacyCard/LegacyStack - retaining existing behaviour instead of removing it I'd say that's a new feature and it should be a What would you like to do here? I see two avenues, and I'd suggest the first:
|
@BPScott This was originally opened with the intent just to change the URLs (in a patch change) and then I saw the rules and thought it would be ideal to update them. It was an error on my part to leave this as a patch. I can revert this and re-add the changes in 2 PRs, a patch change to update the links and a minor change to update the rules so that Card and Stack as well as their legacy components are considered. |
No need to revert and redo from scratch over 2 PRs, I'm fine with just one new PR to fix forwards. It's trivial to update the existing changeset file with the new target of minor |
Description
Part of Polaris#8185.
The Polaris style guide was updated to group components into categories. This updates links to Polaris components to reflect those changes.
Additionally,
Stack
andCard
have been deprecated in favor ofLegacyStack
andLegacyCard
.I've updated the
polaris-no-bare-stack-item
andpolaris-prefer-sectioned-prop
rules and tests to use the legacy components instead.