Remove indirection for stylelint rules #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of spreading configs over multiple files, lets define enabled rules inline its easier to see without moving through multiple files
BPScott
force-pushed
the
stylelint-rules-indirection
branch
from
014dacd
to
1a6b228
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bit like #338 but for stylelint
We have two stylelint configs -
index.jsandprettier.js.index.jsimported a handful of other files that defined if rules were enabled or disabled.That indirection is silly. Let's just put the big list of rules directly into index.js.
This PR removes config/*.js, and places their content directly into index.js