Update eslint-plugin-prettier and remove override for graphql files #341
+10
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of v4.1.0 eslint-plugin-prettier shall inherently skip running over graphql files, so this override is not needed. This means we can remove the override to disable prettier for graphql files, as this had the undesired effect of making eslint's "work out what files to lint based on the file extensions used in overrides" logic think that eslint should try to lint graphql files if you used the `plugin:@shopify/prettier` preset
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of v4.1.0 eslint-plugin-prettier shall inherently skip running over
graphql files, so the override to turn that off is not needed.
This means we can remove the override to disable prettier for graphql
files, as this had the undesired effect of making eslint's "work out
what files to lint based on the file extensions used in overrides" logic
think that eslint should try to lint graphql files if you used the
plugin:@shopify/prettierpreset