Fix compatibility with eslint-plugin-react 7.30.0 #332
+361
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
fix-eslint-plugin-react
branch
2 times, most recently
from
ae80b07
to
5d800b2
Compare
We reached into eslint-plugin-react to access some of its internals, and they moved around in v7.30.0. Copy the utilities that we depend upon into our codebase, and remove the need touch eslint-plugin-react's internals. Also remove usage of Component.detect as it is no longer needed.
BPScott
force-pushed
the
fix-eslint-plugin-react
branch
from
5d800b2
to
3fd2ebf
Compare
vsumner
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #331
@shopify/eslint-pluginreached into eslint-plugin-react to access some of its internal utilities. The location of those internal utilities moved around in v7.30.0 and broke our greedy fingers.This PR copies the utilities that we depend upon into our codebase, and removes the
need to touch eslint-plugin-react's internals. It also removes usage of
Component.detect as it is no longer needed - we only needed it to access the utilities, which now no longer need to be wrapped. jsx-eslint/eslint-plugin-react#3273 suggests that shall result in a small speedup.
Type of change
@shopify/eslint-plugin- minor