Enable @typescript-eslint/consistent-type-imports

This is a valuable rule to make it clear when a token being imported is used strictly for the type system vs a value at runtime. https://typescript-eslint.io/rules/consistent-type-imports/ The rule is auto-fixable
Shopify · Jun 2, 2023 · cef9e49 · cef9e49
1 parent 5ab0fcf
commit cef9e49
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.changeset/fluffy-spoons-admire.md b/.changeset/fluffy-spoons-admire.md
@@ -0,0 +1,5 @@
+---
+'@shopify/eslint-plugin': minor
+---
+
+Enable @typescript-eslint/consistent-type-imports to error
diff --git a/packages/eslint-plugin/lib/config/typescript.js b/packages/eslint-plugin/lib/config/typescript.js
@@ -187,6 +187,8 @@ module.exports = {
         '@typescript-eslint/ban-ts-comment': 'error',
         // Enforce consistent brace style for blocks
         '@typescript-eslint/brace-style': 'error',
+        // Enforce consistent type imports when importing a token as strictly a type vs as a runtime value
+        '@typescript-eslint/consistent-type-imports': 'error',
         // Enforces consistent usage of type assertions.
         '@typescript-eslint/consistent-type-assertions': [
           'error',