-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use Record instead of index signatures
Fix failures
- Loading branch information
Showing
4 changed files
with
9 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@shopify/eslint-plugin': major | ||
--- | ||
|
||
Change the @typescript-eslint/consistent-indexed-object-style rule to use default error settings, aka Record over index signature |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
export function svgOptions(): {[key: string]: unknown}; | ||
export function svgOptions(): Record<string, unknown>; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
declare module '*.scss' { | ||
const classNames: {[key: string]: string}; | ||
const classNames: Record<string, string>; | ||
export default classNames; | ||
} | ||
|
||
declare module '*.css' { | ||
const classNames: {[key: string]: string}; | ||
const classNames: Record<string, string>; | ||
export default classNames; | ||
} |