This repository has been archived by the owner on May 30, 2024. It is now read-only.
Add OpenVSX to release workflow #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Dec 4, 2023
| @@ -56,3 +56,9 @@ jobs: | |||
| node_modules/.bin/vsce publish --pre-release --packagePath vscode-ruby-lsp.vsix | |||
| env: | |||
| VSCE_PAT: ${{ secrets.VSCE_PAT }} | |||
|
|
|||
| # Stable releases for OpenVSX | |||
There was a problem hiding this comment.
There may be some complications with prereleases in OpenVSX so I've skipped that for now.
vinistock
reviewed
Dec 4, 2023
andyw8
force-pushed
the
andyw8/add-openvsx-to-release-workflow
branch
2 times, most recently
from
25efa4f to
43f8fe2
Compare
st0012
approved these changes
Dec 4, 2023
andyw8
force-pushed
the
andyw8/add-openvsx-to-release-workflow
branch
from
43f8fe2 to
d1d6d99
Compare
vinistock
approved these changes
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes Shopify/ruby-lsp#1537
As discussed with @dirceu I have added the token as a repository secret, I don't think it needs be an organization secret.