Backport: set vreplication net read and net write timeout session vars to high values#155
Merged
pawandubey merged 1 commit intov15.0.3-shopify-11from Apr 9, 2024
Merged
Conversation
…values (vitessio#14203) Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com>
pawandubey
commented
Apr 5, 2024
| ) | ||
|
|
||
| func init() { | ||
| servenv.OnParseFor("vttablet", registerFlags) |
Author
There was a problem hiding this comment.
The previous attempt also passed these flags to vtcombo which is used in vttestserver so would be useful in dev and tests, but given that upstream PR does not add it, I am wary of adding to it. Also unsure if the schema migration issue will crop up in dev anyway.
austenLacy
approved these changes
Apr 5, 2024
Author
|
Two checks are failing for non-code reasons:
|
shivnagarajan
approved these changes
Apr 5, 2024
| ) | ||
|
|
||
| func init() { | ||
| servenv.OnParseFor("vttablet", registerFlags) |
Author
@shanth96 the tests were added to a file that does not yet exist in v15. I tried to note that in the PR description. I did not want to introduce the file here since the tests are rather simplistic? Happy to be convinced otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of vitessio@6953390
Redo of #129 onto the newest release.
Part of https://github.com/Shopify/vitess-project/issues/623
Helps with failure of schema changes using
vitessstrategy due to lower than desired timeout values.