[BACK-PORT] Properly support ignore_nulls in CreateLookupVindex (#13913)#122
Merged
austenLacy merged 2 commits intov15.0.3-shopify-7from Sep 19, 2023
Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com>
austenLacy
requested review from
Hammadk,
adisonlampert,
brendar,
shanth96 and
vahe
Signed-off-by: Austen Lacy <austen.lacy@shopify.com>
austenLacy
force-pushed
the
austenlacy/vitess-project-485/backport-ignore_nulls-support-in-createlookupvindex
branch
from
4908d0a to
1b2ba1f
Compare
brendar
approved these changes
Sep 18, 2023
austenLacy
deleted the
austenlacy/vitess-project-485/backport-ignore_nulls-support-in-createlookupvindex
branch
shanth96
pushed a commit
that referenced
this pull request
Mar 21, 2024
…ssio#13913) (#122) * Properly support ignore_nulls in CreateLookupVindex (vitessio#13913) Signed-off-by: Matt Lord <mattalord@gmail.com> * remove new vreplication tests that dont work with v15 Signed-off-by: Austen Lacy <austen.lacy@shopify.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Austen Lacy <austen.lacy@shopify.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Austen Lacy <austen.lacy@shopify.com> (cherry picked from commit ebde310)
shanth96
pushed a commit
that referenced
this pull request
May 10, 2024
…ssio#13913) (#122) * Properly support ignore_nulls in CreateLookupVindex (vitessio#13913) Signed-off-by: Matt Lord <mattalord@gmail.com> * remove new vreplication tests that dont work with v15 Signed-off-by: Austen Lacy <austen.lacy@shopify.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Austen Lacy <austen.lacy@shopify.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Austen Lacy <austen.lacy@shopify.com> (cherry picked from commit ebde310) (cherry picked from commit 07c6f4a)
shivnagarajan
pushed a commit
that referenced
this pull request
May 19, 2024
…ssio#13913) (#122) * Properly support ignore_nulls in CreateLookupVindex (vitessio#13913) Signed-off-by: Matt Lord <mattalord@gmail.com> * remove new vreplication tests that dont work with v15 Signed-off-by: Austen Lacy <austen.lacy@shopify.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Austen Lacy <austen.lacy@shopify.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Austen Lacy <austen.lacy@shopify.com> (cherry picked from commit ebde310) (cherry picked from commit 07c6f4a) (cherry picked from commit 428d1bd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back ports vitessio#13913 from upstream to fix the reported bug for
CreateLookupVindexworkflows not respecting theignore_nullsfield.