Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(products): updating Product Configuration extension points to use block extension api & components #2639

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

kmdavis
Copy link
Contributor

@kmdavis kmdavis commented Feb 14, 2025

Part of https://github.com/Shopify/bundles-app/issues/2968

Background

When the product configuration extension points were first created, all data necessary for rendering had to passed in. This is no longer the case, as ui extensions now have access to a graphql api. The prior PR in this chain added the product or variant id as selected[0].id (the same pattern used by block extensions), and this PR updates the types to reflect this new field, and marks the existing product/productVariant objects as deprecated (we'll remove them in a few months, once all third party apps are no longer using it)

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@kmdavis kmdavis requested review from moraleslevi, hannakebedom and a team February 14, 2025 20:44
@kmdavis kmdavis self-assigned this Feb 14, 2025
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

@kmdavis kmdavis force-pushed the kd/20250214/product-config-api branch from 2297f5c to b8bb3c7 Compare February 14, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant