Added enhancements to our versions docs #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanJolly
reviewed
Feb 14, 2025
Comment on lines
90
to
101
| - Added sizing and fill options to the [Image](/docs/api/pos-ui-extensions/components/image) component. | ||
| - Added sizing and fill options to the[Image](/docs/api/pos-ui-extensions/components/image) component. |
NathanJolly
reviewed
Feb 14, 2025
|
|
||
| ### Important fix in POS 9.27.0 | ||
|
|
||
| - Fixed an issue where the \`Stack\` component was not rendering correctly. By default, \`Stack\` will now always wrap. Additionally, stacks using \`'block'\` will now compress horizontally. Use \`alignContents: 'stretch'\` to take all of the horizontal space. This will not have an impact on layout in previous POS versions. |
There was a problem hiding this comment.
When we change things like this, we should be providing screenshots of the diff. Trying to parse words is incredibly hard. Seeing the diff in images is very easy.
There was a problem hiding this comment.
We're gonna add a code example with a screenshot. I think when we do that, we can just link to that doc from here
NathanJolly
approved these changes
Feb 14, 2025
js-goupil
force-pushed
the
js-fix-versions-docs
branch
from
3984aaf to
229b22e
Compare
NathanJolly
approved these changes
Feb 14, 2025
vctrchu
reviewed
Feb 14, 2025
| @@ -64,6 +61,14 @@ Refer to the [migration guide](/docs/api/pos-ui-extensions/migrating) for more i | |||
| - Removed in POS version: N/A | |||
| - Release day: 1/6/2025 | |||
|
|
|||
| ### Important fix in POS 9.29.0 | |||
|
|
|||
| - Fixed an issue where the \`FormattedTextField\` were rendering black input text in dark mode. It will now render the correct light color variant. | |||
There was a problem hiding this comment.
Suggested change
| - Fixed an issue where the \`FormattedTextField\` were rendering black input text in dark mode. It will now render the correct light color variant. | |
| - Fixed an issue where the \`FormattedTextField\` were rendering black input text in dark mode. |
Do you think we need to explain the correct behaviour?
There was a problem hiding this comment.
were -> was, too, just noticed
There was a problem hiding this comment.
"where the `Stack` component was not"
so I'd add the word component for consistency with the other change below, too
There was a problem hiding this comment.
god bless you boys
js-goupil
force-pushed
the
js-fix-versions-docs
branch
from
229b22e to
8340894
Compare
vctrchu
reviewed
Feb 14, 2025
packages/ui-extensions/docs/surfaces/point-of-sale/staticPages/pages/versions.doc.ts
Outdated
Show resolved
Hide resolved
vctrchu
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Actioning on the feedback that we lacked documentation in the version changes for 2025.1 and POS 9.27.0
Solution
🎩
Checklist