Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote-dom ui_extensions changes customer accounts #2510

Open
wants to merge 15 commits into
base: unstable
Choose a base branch
from

Conversation

oluwatimio
Copy link
Contributor

Background

(Provide a link to any relevant issues AND provide a TLDR of the issue in this pull request)

Solution

(Describe your solution, why this approach was chosen, and what the alternatives/impacts may be)

🎩

  • ...

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@oluwatimio oluwatimio changed the title Remote-dom ui_extensions changes customer accounts [poc] Remote-dom ui_extensions changes customer accounts Dec 4, 2024
@oluwatimio
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @oluwatimio! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/data-extensions": "0.0.0-snapshot-20241204165201",
"@shopify/ui-extensions": "0.0.0-snapshot-20241204165201",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241204165201"

@oluwatimio
Copy link
Contributor Author

/snapit

1 similar comment
@oluwatimio
Copy link
Contributor Author

/snapit

@oluwatimio
Copy link
Contributor Author

/snapit

@oluwatimio
Copy link
Contributor Author

/snapit

@oluwatimio oluwatimio marked this pull request as ready for review January 28, 2025 18:30
@oluwatimio oluwatimio changed the title [poc] Remote-dom ui_extensions changes customer accounts [WIP] Remote-dom ui_extensions changes customer accounts Jan 28, 2025
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

@@ -47,6 +47,8 @@ export function reactExtension<Target extends RenderExtensionTarget>(
<ExtensionApiContext.Provider value={api}>
<ErrorBoundary>{element}</ErrorBoundary>
</ExtensionApiContext.Provider>,
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring for now since we need checkout's changes here so the types are in line

@oluwatimio
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @oluwatimio! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/data-extensions": "0.0.0-snapshot-20250128203345",
"@shopify/ui-extensions": "0.0.0-snapshot-20250128203345",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20250128203345"

@oluwatimio
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @oluwatimio! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/data-extensions": "0.0.0-snapshot-20250128205831",
"@shopify/ui-extensions": "0.0.0-snapshot-20250128205831",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20250128205831"

"nodemon": "^2.0.4",
"prettier": "^2.8.0",
"react": ">=18.0.0",
"typescript": "^4.9.0"
},
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"resolutions": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of loom, we need to address this

@oluwatimio oluwatimio changed the title [WIP] Remote-dom ui_extensions changes customer accounts Remote-dom ui_extensions changes customer accounts Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant