-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote-dom ui_extensions changes customer accounts #2510
base: unstable
Are you sure you want to change the base?
Conversation
/snapit |
🫰✨ Thanks @oluwatimio! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/data-extensions": "0.0.0-snapshot-20241204165201",
"@shopify/ui-extensions": "0.0.0-snapshot-20241204165201",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241204165201" |
/snapit |
1 similar comment
/snapit |
/snapit |
/snapit |
We detected some changes in |
@@ -47,6 +47,8 @@ export function reactExtension<Target extends RenderExtensionTarget>( | |||
<ExtensionApiContext.Provider value={api}> | |||
<ErrorBoundary>{element}</ErrorBoundary> | |||
</ExtensionApiContext.Provider>, | |||
// eslint-disable-next-line @typescript-eslint/ban-ts-comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring for now since we need checkout's changes here so the types are in line
/snapit |
🫰✨ Thanks @oluwatimio! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/data-extensions": "0.0.0-snapshot-20250128203345",
"@shopify/ui-extensions": "0.0.0-snapshot-20250128203345",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20250128203345" |
/snapit |
🫰✨ Thanks @oluwatimio! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/data-extensions": "0.0.0-snapshot-20250128205831",
"@shopify/ui-extensions": "0.0.0-snapshot-20250128205831",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20250128205831" |
"nodemon": "^2.0.4", | ||
"prettier": "^2.8.0", | ||
"react": ">=18.0.0", | ||
"typescript": "^4.9.0" | ||
}, | ||
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" | ||
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e", | ||
"resolutions": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of loom, we need to address this
Background
(Provide a link to any relevant issues AND provide a TLDR of the issue in this pull request)
Solution
(Describe your solution, why this approach was chosen, and what the alternatives/impacts may be)
🎩
Checklist