-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contentFor tag grammar to properly extract arguments #648
Merged
+91
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
reviewed
Dec 4, 2024
charlespwd
reviewed
Dec 4, 2024
veken1199
force-pushed
the
feken/update-fix-content-for-grammer
branch
from
December 4, 2024 14:52
af44837
to
0e525f9
Compare
charlespwd
reviewed
Dec 4, 2024
charlespwd
reviewed
Dec 4, 2024
charlespwd
reviewed
Dec 4, 2024
packages/theme-check-common/src/checks/deprecated-content-for-arguments/index.ts
Outdated
Show resolved
Hide resolved
veken1199
force-pushed
the
feken/update-fix-content-for-grammer
branch
2 times, most recently
from
December 4, 2024 17:56
a27fb8e
to
36d5bc7
Compare
veken1199
force-pushed
the
feken/update-fix-content-for-grammer
branch
from
December 4, 2024 18:12
36d5bc7
to
6731fac
Compare
albchu
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
veken1199
force-pushed
the
feken/update-fix-content-for-grammer
branch
from
December 4, 2024 18:39
6731fac
to
7f959f6
Compare
charlespwd
reviewed
Dec 4, 2024
charlespwd
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the nitpick, this LGTM :) Feel free to merge after!
veken1199
force-pushed
the
feken/update-fix-content-for-grammer
branch
from
December 4, 2024 19:53
7f959f6
to
8912fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
It seems that the grammar we had for content_for did not properly extract the contentFor liquid tag argument and convert them into array.
In this PR we have:
.
closest.
instead ofcontext.
DeprecatedContentForArgument
check that reports a warning when contentFor tag containscontext.
changeset
allChecks
array insrc/checks/index.ts
yarn build
and committed the updated configuration filestheme-app-extension.yml
configchangeset
changeset