Run Theme Check with the most updated resources (objects, filters, and tags) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
reviewed
Feb 16, 2023
karreiro
force-pushed
the
fix-706
branch
2 times, most recently
from
83a3605 to
bee2b63
Compare
karreiro
commented
Apr 21, 2023
| @@ -46,6 +46,7 @@ jobs: | |||
| with: | |||
| repository: "shopify/dawn" | |||
| path: "./dawn" | |||
| ref: 'v6.0.0' | |||
There was a problem hiding this comment.
I've introduced a fixed Dawn version, so we may ensure that an older version of Theme Check is running with a compatible Dawn. Otherwise, Them Check fails with new features in the upstream Dawn (e.g., UnknownFilter).
|
@charlespwd this PR is ready for a re-review :) |
charlespwd
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
entrypoint.shto run Theme Check with the most updated resources (objects, filters, and tags).