New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Module builder pattern for method instrumentation -- part 2 #114

Open

maximebedard wants to merge 3 commits into main from instrumentation_modules_2

maximebedard commented Nov 8, 2017 •

edited

Loading

Follow-up on #104. This PR aims to simplify how the buckets are generated and offer hooks to control what the user wants to do with the metric.

This is still a huge WIP, any feedback is very welcome :)

Ongoing problems:

Name needs to be specified (do we want to magically infer things?)
Add helpers such as count_success & measure_success
Extract the inner behaviour in order to refactor other methods such as #count and #measure

wvanbergen and others added 3 commits

November 8, 2017 09:04


          Use Module builder pattern for method instrumentation.

6502c7d


          Test singleton_class behaviour as well.

fe082fa


          Add MethodMeasurer and make sure method visibility is preserved

0d950cb

maximebedard mentioned this pull request

Send measure metric even when the block raises #111

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet