Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'whitelist' term and unnecessary sentences #81

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Remove 'whitelist' term and unnecessary sentences #81

merged 1 commit into from
Jun 25, 2021

Conversation

Paulinakhew
Copy link
Contributor

@Paulinakhew Paulinakhew commented Jun 21, 2021 •
edited
Loading

WHY are these changes introduced?

WHAT is this pull request doing?

  • change whitelist to allow
  • remove redundant lines that restate the Shopify\Auth\OAuth::callback parameters

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@Paulinakhew Paulinakhew requested a review from a team as a code owner June 21, 2021 15:26
paulomarg
paulomarg approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@Paulinakhew Paulinakhew merged commit c9ab325 into main Jun 25, 2021
@Paulinakhew Paulinakhew deleted the update-oauth-docs branch June 25, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paulinakhew @paulomarg