This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Add support for private apps #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
commented
Feb 9, 2021
thecodepixi
reviewed
Feb 9, 2021
paulomarg
force-pushed
the
add_private_app_support
branch
from
fc0fa1f
to
48de685
Compare
paulomarg
force-pushed
the
add_private_app_support
branch
from
48de685
to
7c9201a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Currently, both the GraphQL and REST clients require an access token when created, which works for public / custom apps, but not for private ones since they don't go through OAuth. This PR aims to solve that problem by adding a setting to the library to indicate that the current app is a private one.
WHAT is this pull request doing?
If the app is private, the clients will automatically switch over to using the app's password as the access token, rather than the one obtained in the constructor. That way, callers just need to know the shop for which they're making requests and the library handles the logic of which value to send as the access token header.
Type of change