This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Force / path on session cookie #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
fix_issue_with_session_cookie_path
branch
from
5ba1a3b
to
ea0a42c
Compare
teddyhwang
approved these changes
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
After doing OAuth on a non-embedded app, we set a cookie with the Shopify session id, but it seems that Chrome is defaulting the
pathfor that cookie to/api/authin the app template (i.e. the path that initiated the request).WHAT is this pull request doing?
Forcing the path on the session cookie to be
/, which enables any request in the app to use it.Type of change
Checklist