This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Allow redis options in session storage #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
add_redis_client_options
branch
from
99eae3c
to
26c8a22
Compare
paulomarg
force-pushed
the
add_redis_client_options
branch
from
26c8a22
to
7ea3f39
Compare
mkevinosullivan
approved these changes
Jul 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes #416
We currently don't allow our session storage strategy for Redis to pass any options to the client it creates, which makes it hard to customize it.
WHAT is this pull request doing?
Having our internal options used to create the client extend from the default client options, so that we essentially provide any functionality available to the client itself to apps using the library.
Type of change
Checklist